Skip to content

Commit 9acc052

Browse files
benzonicoWohops
authored andcommitted
Fix quality flaw: Coverage on missing new line
1 parent 07b0632 commit 9acc052

File tree

3 files changed

+5
-18
lines changed

3 files changed

+5
-18
lines changed

.gitattributes

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1 +1,2 @@
11
java-frontend/src/test/files/highlighter/SonarSymTable.java eol=lf
2+
java-checks/src/test/files/checks/NonEmptyFile.java eol=cr

java-checks/src/main/java/org/sonar/java/checks/MissingNewLineAtEndOfFileCheck.java

Lines changed: 3 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -21,33 +21,20 @@
2121

2222
import org.sonar.check.Rule;
2323
import org.sonar.java.RspecKey;
24-
import org.sonar.plugins.java.api.IssuableSubscriptionVisitor;
24+
import org.sonar.plugins.java.api.JavaFileScanner;
2525
import org.sonar.plugins.java.api.JavaFileScannerContext;
26-
import org.sonar.plugins.java.api.tree.Tree;
27-
28-
import java.util.Collections;
29-
import java.util.List;
3026

3127
@Rule(key = "S00113")
3228
@RspecKey("S113")
33-
public class MissingNewLineAtEndOfFileCheck extends IssuableSubscriptionVisitor {
29+
public class MissingNewLineAtEndOfFileCheck implements JavaFileScanner {
3430

35-
@Override
36-
public List<Tree.Kind> nodesToVisit() {
37-
return Collections.emptyList();
38-
}
3931

4032
@Override
4133
public void scanFile(JavaFileScannerContext context) {
42-
super.context = context;
4334
String content = context.getFileContent();
44-
if(content.isEmpty()) {
45-
return;
46-
}
47-
4835
char lastChar = content.charAt(content.length() - 1);
4936
if( lastChar != '\n' && lastChar != '\r') {
50-
addIssueOnFile("Add a new line at the end of this file.");
37+
context.addIssueOnFile(this, "Add a new line at the end of this file.");
5138
}
5239
}
5340
}

java-checks/src/test/files/checks/NonEmptyFile.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1 @@
1-
class NonEmptyFile {
2-
}
1+
class NonEmptyFile {}

0 commit comments

Comments
 (0)