i cant get sixel/kittygraphics to work

[anispwyn]

I am following the example in https://pkg.go.dev/git.sr.ht/~rockorager/vaxis#example-Image

the image is a 1:1 size with a resolution of 512x512
I have no idea why it won't render, I've tried kitty and foot terminal

Do you have an example of a working image/code I could try?

[sewnie]

I can replicate this issue.

[codelif]

After creating an Image (vx.NewImage), you need to call Resize on the image before calling Draw (this is because Draw uses an internal buffer to "draw", but it is only (re)populated on Resize and not when NewImage is called).

And after calling Resize you need to wait for a Redraw{} event on the event queue before calling Draw.
This is because resizing is done asynchronously, and after the goroutine returns it sends a Redraw{} event. So unless you wait for that event, the internal buffer might be empty/broken. (its a race)

So, ideally to draw an image, you'd do something like this:

import (
	"image/png"
	"os"

	"git.sr.ht/~rockorager/vaxis"
)

func main() {
	f, err := os.Open("/home/harsh/Pictures/skong.png")
	if err != nil {
		panic(err)
	}
	img, err := png.Decode(f)
	if err != nil {
		panic(err)
	}

	vx, err := vaxis.New(vaxis.Options{})
	if err != nil {
		panic(err)
	}

	defer vx.Close()

	vimg, err := vx.NewImage(img)
	if err != nil {
		panic(err)
	}

	w, h := 20, 10
	vimg.Resize(w, h)

	for ev := range vx.Events() {
		switch ev := ev.(type) {
		case vaxis.Redraw:
			vimg.Draw(vx.Window())
			vx.Render()
		case vaxis.Key:
			if ev.String() == "Ctrl+c" {
				return
			}
		}
	}

}

Though even this approach has its flaws, since you cannot determine where the Redraw{} event is coming from. (from the Resize thread or some other SyncFunc)
I have no idea why this is the case.

I have made a patch to improve this API, though it is very specific to my personal projects so I don't think it should be merged here.

I will see if I can incorporate those fixes in a more compatible manner when I am done with my personal projects. For now you can see the patch here