Revert exception handling extending the offset

leojuurinen-vala · leojuurinen-vala · commit b4c1a1a164f4 · 2025-12-01T21:59:41.000+02:00
diff --git a/packages/robot/src/robotcode/robot/diagnostics/library_doc.py b/packages/robot/src/robotcode/robot/diagnostics/library_doc.py
@@ -2429,7 +2429,7 @@ def _get_initial_handler(self, library: Any, name: Any, method: Any) -> Any:
                 # TODO: add type information of the value including dict key names and member names
                 libdoc.variables = []
                 for name, value in importer.import_variables(import_name, args):
-                    var_info = variable_info.get(name, (1, 0, len(name)))
+                    var_info = variable_info.get(name, (1, 0, 0))
                     libdoc.variables.append(
                         ImportedVariableDefinition(
                             line_no=var_info[0],
diff --git a/tests/robotcode/language_server/robotframework/parts/_regtest_outputs/rf50/test_goto_definition.test_definition[goto.robot-075-013-Imported_Variable].out b/tests/robotcode/language_server/robotframework/parts/_regtest_outputs/rf50/test_goto_definition.test_definition[goto.robot-075-013-Imported_Variable].out
@@ -13,14 +13,14 @@ result:
       line: 75
   target_range:
     end:
-      character: 17
+      character: 0
       line: 0
     start:
       character: 0
       line: 0
   target_selection_range:
     end:
-      character: 17
+      character: 0
       line: 0
     start:
       character: 0
diff --git a/tests/robotcode/language_server/robotframework/parts/_regtest_outputs/rf50/test_goto_definition.test_definition[goto.robot-075-020-Imported_Variable].out b/tests/robotcode/language_server/robotframework/parts/_regtest_outputs/rf50/test_goto_definition.test_definition[goto.robot-075-020-Imported_Variable].out
@@ -13,14 +13,14 @@ result:
       line: 75
   target_range:
     end:
-      character: 17
+      character: 0
       line: 0
     start:
       character: 0
       line: 0
   target_selection_range:
     end:
-      character: 17
+      character: 0
       line: 0
     start:
       character: 0
diff --git a/tests/robotcode/language_server/robotframework/parts/_regtest_outputs/rf50/test_goto_definition.test_definition[goto.robot-075-026-Imported_Variable].out b/tests/robotcode/language_server/robotframework/parts/_regtest_outputs/rf50/test_goto_definition.test_definition[goto.robot-075-026-Imported_Variable].out
@@ -13,14 +13,14 @@ result:
       line: 75
   target_range:
     end:
-      character: 17
+      character: 0
       line: 0
     start:
       character: 0
       line: 0
   target_selection_range:
     end:
-      character: 17
+      character: 0
       line: 0
     start:
       character: 0
diff --git a/tests/robotcode/language_server/robotframework/parts/_regtest_outputs/rf50/test_goto_implementation.test_implementation[goto.robot-075-013-Imported_Variable].out b/tests/robotcode/language_server/robotframework/parts/_regtest_outputs/rf50/test_goto_implementation.test_implementation[goto.robot-075-013-Imported_Variable].out
@@ -13,14 +13,14 @@ result:
       line: 75
   target_range:
     end:
-      character: 17
+      character: 0
       line: 0
     start:
       character: 0
       line: 0
   target_selection_range:
     end:
-      character: 17
+      character: 0
       line: 0
     start:
       character: 0
diff --git a/tests/robotcode/language_server/robotframework/parts/_regtest_outputs/rf50/test_goto_implementation.test_implementation[goto.robot-075-020-Imported_Variable].out b/tests/robotcode/language_server/robotframework/parts/_regtest_outputs/rf50/test_goto_implementation.test_implementation[goto.robot-075-020-Imported_Variable].out
@@ -13,14 +13,14 @@ result:
       line: 75
   target_range:
     end:
-      character: 17
+      character: 0
       line: 0
     start:
       character: 0
       line: 0
   target_selection_range:
     end:
-      character: 17
+      character: 0
       line: 0
     start:
       character: 0
diff --git a/tests/robotcode/language_server/robotframework/parts/_regtest_outputs/rf50/test_goto_implementation.test_implementation[goto.robot-075-026-Imported_Variable].out b/tests/robotcode/language_server/robotframework/parts/_regtest_outputs/rf50/test_goto_implementation.test_implementation[goto.robot-075-026-Imported_Variable].out
@@ -13,14 +13,14 @@ result:
       line: 75
   target_range:
     end:
-      character: 17
+      character: 0
       line: 0
     start:
       character: 0
       line: 0
   target_selection_range:
     end:
-      character: 17
+      character: 0
       line: 0
     start:
       character: 0
diff --git a/tests/robotcode/language_server/robotframework/parts/_regtest_outputs/rf60/test_goto_definition.test_definition[goto.robot-075-013-Imported_Variable].out b/tests/robotcode/language_server/robotframework/parts/_regtest_outputs/rf60/test_goto_definition.test_definition[goto.robot-075-013-Imported_Variable].out
@@ -13,14 +13,14 @@ result:
       line: 75
   target_range:
     end:
-      character: 17
+      character: 0
       line: 0
     start:
       character: 0
       line: 0
   target_selection_range:
     end:
-      character: 17
+      character: 0
       line: 0
     start:
       character: 0
diff --git a/tests/robotcode/language_server/robotframework/parts/_regtest_outputs/rf60/test_goto_definition.test_definition[goto.robot-075-020-Imported_Variable].out b/tests/robotcode/language_server/robotframework/parts/_regtest_outputs/rf60/test_goto_definition.test_definition[goto.robot-075-020-Imported_Variable].out
@@ -13,14 +13,14 @@ result:
       line: 75
   target_range:
     end:
-      character: 17
+      character: 0
       line: 0
     start:
       character: 0
       line: 0
   target_selection_range:
     end:
-      character: 17
+      character: 0
       line: 0
     start:
       character: 0
diff --git a/tests/robotcode/language_server/robotframework/parts/_regtest_outputs/rf60/test_goto_definition.test_definition[goto.robot-075-026-Imported_Variable].out b/tests/robotcode/language_server/robotframework/parts/_regtest_outputs/rf60/test_goto_definition.test_definition[goto.robot-075-026-Imported_Variable].out
@@ -13,14 +13,14 @@ result:
       line: 75
   target_range:
     end:
-      character: 17
+      character: 0
       line: 0
     start:
       character: 0
       line: 0
   target_selection_range:
     end:
-      character: 17
+      character: 0
       line: 0
     start:
       character: 0
diff --git a/tests/robotcode/language_server/robotframework/parts/_regtest_outputs/rf60/test_goto_implementation.test_implementation[goto.robot-075-013-Imported_Variable].out b/tests/robotcode/language_server/robotframework/parts/_regtest_outputs/rf60/test_goto_implementation.test_implementation[goto.robot-075-013-Imported_Variable].out
@@ -13,14 +13,14 @@ result:
       line: 75
   target_range:
     end:
-      character: 17
+      character: 0
       line: 0
     start:
       character: 0
       line: 0
   target_selection_range:
     end:
-      character: 17
+      character: 0
       line: 0
     start:
       character: 0
diff --git a/tests/robotcode/language_server/robotframework/parts/_regtest_outputs/rf60/test_goto_implementation.test_implementation[goto.robot-075-020-Imported_Variable].out b/tests/robotcode/language_server/robotframework/parts/_regtest_outputs/rf60/test_goto_implementation.test_implementation[goto.robot-075-020-Imported_Variable].out
@@ -13,14 +13,14 @@ result:
       line: 75
   target_range:
     end:
-      character: 17
+      character: 0
       line: 0
     start:
       character: 0
       line: 0
   target_selection_range:
     end:
-      character: 17
+      character: 0
       line: 0
     start:
       character: 0
diff --git a/tests/robotcode/language_server/robotframework/parts/_regtest_outputs/rf60/test_goto_implementation.test_implementation[goto.robot-075-026-Imported_Variable].out b/tests/robotcode/language_server/robotframework/parts/_regtest_outputs/rf60/test_goto_implementation.test_implementation[goto.robot-075-026-Imported_Variable].out
@@ -13,14 +13,14 @@ result:
       line: 75
   target_range:
     end:
-      character: 17
+      character: 0
       line: 0
     start:
       character: 0
       line: 0
   target_selection_range:
     end:
-      character: 17
+      character: 0
       line: 0
     start:
       character: 0
diff --git a/tests/robotcode/language_server/robotframework/parts/_regtest_outputs/rf61/test_goto_definition.test_definition[goto.robot-075-013-Imported_Variable].out b/tests/robotcode/language_server/robotframework/parts/_regtest_outputs/rf61/test_goto_definition.test_definition[goto.robot-075-013-Imported_Variable].out
@@ -13,14 +13,14 @@ result:
       line: 75
   target_range:
     end:
-      character: 17
+      character: 0
       line: 0
     start:
       character: 0
       line: 0
   target_selection_range:
     end:
-      character: 17
+      character: 0
       line: 0
     start:
       character: 0
diff --git a/tests/robotcode/language_server/robotframework/parts/_regtest_outputs/rf61/test_goto_definition.test_definition[goto.robot-075-020-Imported_Variable].out b/tests/robotcode/language_server/robotframework/parts/_regtest_outputs/rf61/test_goto_definition.test_definition[goto.robot-075-020-Imported_Variable].out
@@ -13,14 +13,14 @@ result:
       line: 75
   target_range:
     end:
-      character: 17
+      character: 0
       line: 0
     start:
       character: 0
       line: 0
   target_selection_range:
     end:
-      character: 17
+      character: 0
       line: 0
     start:
       character: 0
diff --git a/tests/robotcode/language_server/robotframework/parts/_regtest_outputs/rf61/test_goto_definition.test_definition[goto.robot-075-026-Imported_Variable].out b/tests/robotcode/language_server/robotframework/parts/_regtest_outputs/rf61/test_goto_definition.test_definition[goto.robot-075-026-Imported_Variable].out
@@ -13,14 +13,14 @@ result:
       line: 75
   target_range:
     end:
-      character: 17
+      character: 0
       line: 0
     start:
       character: 0
       line: 0
   target_selection_range:
     end:
-      character: 17
+      character: 0
       line: 0
     start:
       character: 0
diff --git a/tests/robotcode/language_server/robotframework/parts/_regtest_outputs/rf61/test_goto_implementation.test_implementation[goto.robot-075-013-Imported_Variable].out b/tests/robotcode/language_server/robotframework/parts/_regtest_outputs/rf61/test_goto_implementation.test_implementation[goto.robot-075-013-Imported_Variable].out
@@ -13,14 +13,14 @@ result:
       line: 75
   target_range:
     end:
-      character: 17
+      character: 0
       line: 0
     start:
       character: 0
       line: 0
   target_selection_range:
     end:
-      character: 17
+      character: 0
       line: 0
     start:
       character: 0
diff --git a/tests/robotcode/language_server/robotframework/parts/_regtest_outputs/rf61/test_goto_implementation.test_implementation[goto.robot-075-020-Imported_Variable].out b/tests/robotcode/language_server/robotframework/parts/_regtest_outputs/rf61/test_goto_implementation.test_implementation[goto.robot-075-020-Imported_Variable].out
@@ -13,14 +13,14 @@ result:
       line: 75
   target_range:
     end:
-      character: 17
+      character: 0
       line: 0
     start:
       character: 0
       line: 0
   target_selection_range:
     end:
-      character: 17
+      character: 0
       line: 0
     start:
       character: 0
diff --git a/tests/robotcode/language_server/robotframework/parts/_regtest_outputs/rf61/test_goto_implementation.test_implementation[goto.robot-075-026-Imported_Variable].out b/tests/robotcode/language_server/robotframework/parts/_regtest_outputs/rf61/test_goto_implementation.test_implementation[goto.robot-075-026-Imported_Variable].out
@@ -13,14 +13,14 @@ result:
       line: 75
   target_range:
     end:
-      character: 17
+      character: 0
       line: 0
     start:
       character: 0
       line: 0
   target_selection_range:
     end:
-      character: 17
+      character: 0
       line: 0
     start:
       character: 0
