-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Letterbox of images #505
Comments
Hi @hardikdava 👋🏻 Yup! That's an excellent idea. But then your |
Hi @SkalskiP 👋 , you are absolutely correct. |
@hardikdava, what is the meaning of all of those arguments? Is that function definition copied from YOLOv8? |
Yeah, for a quick info. But we can modify them and use only needed. |
We probably should if we don't want licensing issues. |
Hey @SkalskiP how are you doing on this? If I'm not mistaken this is the same as used in DETR transformation and we could copy it from the transformers library. Let me know if you have the bandwidth to take care of this issue otherwise I'd love to help out |
This issue was implemented via #1028. |
Hi @hardikdava 👋 Good to see you in supervision again :) Unfortunately not. Letterbox resizes the image and then applies letterboxing, so undoing the effect is tricky without knowing the exact params it used. Exposing those would make the API messy. |
@LinasKo can't we recalculate them based on knowing |
My bad, you're right. I thought it was automatic. I'm very short on time this week, but would be happy to review a PR or implement it when I have a spare minute. Should be a tiny feature. Would that be something you have time for, or shall I put it on my backlog? |
Search before asking
Description
It would be great to have a feature which resize images as per letterbox concept i.e. resize based on maximum size and adding padding to an image. This is very helpful resize method to increase result quality.
Use case
Additional
use case:
Are you willing to submit a PR?
The text was updated successfully, but these errors were encountered: