Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page name collision when they use a mix of unicode and ascii characters #94

Open
Stvad opened this issue Feb 15, 2022 · 0 comments
Open
Labels
bug Something isn't working

Comments

@Stvad
Copy link
Member

Stvad commented Feb 15, 2022

Current page naming logic normalizes page names to create readable URLs. Part of that normalization is removing unicode characters.

When it's fully comprized of unicode characters - the original transformation returns an empty string and there is an additional logic to handle that case. Unfortunately another case is not handled rn:

🙂1 and 🙀1 would resolve to the same page name - 1 (and special logic won't kick-in as it's not empty)

requirements:

  • Map pages like this onto distinct URLs
  • Minimize change in name-structure otherwise. Ideally avoid any changes not related to the affected pages. As changing the name structure generally would break already existing links to gardens.

Example garden: https://nicolejiang.roam.garden

example 1
example 2

@Stvad Stvad added the bug Something isn't working label Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant