Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[import] SEARCH_SERVICE_TOPIC observer in Telemetry breaks About #152

Open
rmottola opened this issue Sep 6, 2023 · 1 comment
Open

[import] SEARCH_SERVICE_TOPIC observer in Telemetry breaks About #152

rmottola opened this issue Sep 6, 2023 · 1 comment

Comments

@rmottola
Copy link
Owner

rmottola commented Sep 6, 2023

From old project

In TelemetryEnvironment.jsm, this observer addition:

Services.obs.addObserver(this, SEARCH_SERVICE_TOPIC, false);

causes the home page AboutHome not to completely load the search engine and not to initialize "session restore". No information is added in the console.
@rmottola
Copy link
Owner Author

Things changed after importing newtab. Session restore is not correctly initialized (needs a refresh) independently from these observers, so they have been added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rmottola