Built with WebRTC even if specified '--disable-webrtc'

[donmor]

I'm trying to build Arctic-Fox on loongarch64, a new RISC architecture from Loongson. I patched some files and added some --enable/with-system-xxx to use packages installed using apt. Eventually it stopped here:

...
In file included from /home/donmor/Arctic-Fox/ipc/chromium/src/base/port.h:9,
                 from /home/donmor/Arctic-Fox/ipc/chromium/src/base/basictypes.h:12,
                 from /home/donmor/Arctic-Fox/ipc/chromium/src/base/process_util.h:11,
                 from../../dist/include/ipc/IPCMessageUtils.h:10,
                 from../../ipc/ipdl/_ipdlheaders/mozilla/ipc/PBackground.h:12,
                 from../../ipc/ipdl/_ipdlheaders/mozilla/ipc/PBackgroundChild.h:9,
                 from /home/donmor/Arctic-Fox/ipc/glue/BackgroundChildImpl.h:9,
                 from /home/donmor/Arctic-Fox/ipc/glue/BackgroundChildImpl.cpp:5:
/home/donmor/Arctic-Fox/media/webrtc/trunk/build/build_config.h:164:2: error: #error Please add support for your architecture in build/build_config.h
  164 | #error Please add support for your architecture in build/build_config.h
...
The following command failed to execute properly:
g++ -o BackgroundChildImpl.o -c -I/home/donmor/Arctic-Fox/obj-loongarch64-unknown-linux-gnu/dist/stl_wrappers -I/home/donmor/Arctic-Fox/obj-loongarch64-unknown-linux-gnu/dist/system_wrappers -include/home/donmor/Arctic-Fox/confi g/gcc_hidden.h -DWEBRTC_POSIX -DOS_POSIX=1 -DOS_LINUX=1 -DMOZ_CHILD_PROCESS_NAME="plugin-container" -DM0Z_CHILD_PROCESS_NAME_PIE="" -DMoZ_CHILD_PROCESS_BUNDLE="plugin-container.app/Contents/MacOS/" -DDLL_PREFIX="lib" -DDLL_SUFFIX=".So"-D STATIC_EXPORTABLE_JS_API-DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/home/donmor/Arctic-Fox/ipc/glue -I. -I/home/donmor/Arctic-Fox/caps -I/home/donmor/Arctic-Fox/dom/broadcastchannel -I/home/donmor/Arctic-Fox/dom/indexedDB -I/home/donmor/Arct ic-Fox/dom/workers -I/home/donmor/Arctic-Fox/media/webrtc/trunk-I/home/donmor/Arctic-Fox/xpcom/build-I/home/donmor/Arctic-Fox/toolkit/xre-I/home/donmor/Arctic-Fox/xpcom/threads -I../../ipc/ipdl/_ipdlheaders -I/home/donmor/Arctic-Fox/ip c/chromium/src -I/home/donmor/Arctic-Fox/ipc/glue -I../../dist/include -I/usr/include/nspr-I/usr/include/nss -I/usr/include/pixman-1 -fPIC -DMOZILLA_CLIENT -include../../mozilla-config.h-MD -MP -MF.deps/BackgroundchildImpl.o.pp -Wall -Wempty-body -Woverloaded-virtual -Wsign-compare -wwrite-strings -Wno-invalid-offsetof -Wcast-align -fno-exceptions -fno-strict-aliasing -fno-delete-null-pointer-checks -fno-lifetime-dse -fno-schedule-insns2 -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -std=gnu++0x -pthread -pipe -DNDEBUG -DTRIMMED -g -g0 -02 -fno-delete-null-pointer-checks -fno-lifetime-dse -fno-schedule-insns2 -fomit-frame-pointer /home/donmor/Arctic-Fox/ipc/glue/Backgro undChildImpl.cpp
gmake[5]:*** [/home/donmor/Arctic-Fox/config/rules.mk:957: BackgroundChildImpl.o] Error 1
gmake[4]:*** [/home/donmor/Arctic-Fox/config/recurse.mk:71:ipc/glue/target] Error 2
gmake[4]:*** Waiting for unfinished jobs....
libtoolkit_xre.a.desc
gmake[3]:*** [/home/donmor/Arctic-Fox/config/recurse.mk:33: compile] Error 2
gmake[2]:***[/home/donmor/Arctic-Fox/config/rules.mk:547: default] Error 2
gmake[1]:*** [/home/donmor/Arctic-Fox/client.mk:397: realbuild] Error 2
gmake:***[client.mk:171:build] Error 2
294 compiler warnings present.

It seems that WebRTC is currently not supported on this platform, and should be disabled. But there is already --disable-webrtc in my .mozconfig.

[rmottola]

--disable-webrtc works, it is a configuration I occasionally tests. However perhaps it does not disable building totally? I'll have a look.

[rmottola]

Would you mind retrying current dev? there has been some build system fixes @donmor