Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthrough인덱스 메타/타이틀 업데이트와 함께 약관·개인정보·서비스 소개 페이지 및 공통 레이아웃/섹션 컴포넌트가 추가되었고, 미완료 인터뷰 세션 재개(모달·API·스냅샷) 기능이 도입되었습니다. 계정 삭제 API 연동·UI, 관리자 콘솔의 접속 요약·복구 기능 확장, 프로필 기반 브라우저 세션 가드 전환, 인증 푸터 재사용도 포함됩니다. Changes
Sequence Diagram(s)sequenceDiagram
participant User as 사용자
participant UI as 인터뷰 UI
participant API as Interview API
participant Modal as ResumeSessionModal
participant Snap as SnapshotBuilder
User->>UI: 페이지 진입
UI->>API: getLatestIncompleteTechSession()/getLatestIncompleteMockSession()
API-->>UI: pendingResumeSession 반환
UI->>Modal: 모달 표시 (pendingSession)
alt 재개 선택
User->>Modal: 이어서 하기 클릭
Modal->>Snap: buildResumedSessionSnapshot(session)
Snap-->>UI: 세션 스냅샷
UI->>API: 세션 복구/진행 호출 (네비게이트)
API-->>UI: 세션 진행 응답
else 해제 선택
User->>Modal: 아니요 클릭
Modal->>API: dismissTechSession()/dismissMockSession(sessionId)
API-->>UI: 해제 완료
UI->>UI: 상태 초기화
end
sequenceDiagram
participant User as 사용자
participant MyPage as MyPage
participant Modal as DeleteAccountConfirmModal
participant API as userApi
participant Session as SessionMgr
participant Router as 라우터
User->>MyPage: 회원 탈퇴 버튼 클릭
MyPage->>Modal: 모달 표시
User->>Modal: 탈퇴 확인
Modal->>API: deleteMyAccount()
API-->>Modal: 삭제 성공
Modal->>Session: clearAuthenticatedBrowserSession()
Session-->>Router: /login으로 이동 (로그아웃/세션 정리)
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 951b0a9d08
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| setLoadingMembers(false); | ||
| } | ||
| }, [memberSize]); | ||
| }, [memberKeyword, memberSize]); |
There was a problem hiding this comment.
loadMembers is now recreated whenever memberKeyword changes, and the mount-time initialize effect depends on loadMembers, so every member search triggers a full re-initialization (profile + sets + categories reload and loadingPage spinner) instead of only refreshing the member table. This causes unnecessary network load and visible UI flicker during normal filtering; the initialization path should be decoupled from search-term-driven callback identity.
Useful? React with 👍 / 👎.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 7
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (3)
src/lib/apiClient.js (1)
37-49:⚠️ Potential issue | 🟠 Major모든 HTTP 메서드에서 401 재시도 활성화로 인한 멱등성 위험
retryOnUnauthorized기본값이true로 설정되어, 명시하지 않은 모든 POST/PUT/PATCH/DELETE 작업이 401 응답 시 자동으로 재시도됩니다.
src/lib/interviewApi.js의dismissTechSession,dismissMockSession등 POST 요청들이 이를 명시하지 않아 자동 재시도 대상이 됩니다. 이 작업들이 멱등하지 않다면 중복 처리 위험이 있습니다.비교:
src/lib/paymentApi.js의confirmPointCharge,refundPointCharge는 민감한 작업이므로 명시적으로retryOnUnauthorized: false를 설정합니다.비멱등 작업(
dismissTechSession,dismissMockSession, 그 외 상태 변경 작업)은 명시적으로retryOnUnauthorized: false를 설정하거나, 백엔드 엔드포인트가 멱등성을 보장하는지 확인이 필요합니다.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/lib/apiClient.js` around lines 37 - 49, The current default retryOnUnauthorized behavior in apiClient (variable retryOnUnauthorized used around executeJsonRequest and refreshAuthSession) enables automatic 401 retry for all methods and risks double-executing non-idempotent actions; fix by making retryOnUnauthorized false for unsafe HTTP verbs or explicitly disabling it on non-idempotent callers: either change the default logic so retryOnUnauthorized defaults to false for methods other than GET/HEAD/OPTIONS (inspect options.method before setting retryOnUnauthorized) or update callers like dismissTechSession and dismissMockSession in interviewApi to pass retryOnUnauthorized: false when calling the API, ensuring executeJsonRequest/refreshAuthSession flow will not auto-retry those POST state-changing requests.src/components/BrowserSessionGuard.jsx (1)
19-25:⚠️ Potential issue | 🟡 MinorlocalStorage 마커를 서버 검증 없이 신뢰
hasAuthenticatedBrowserSession()은 localStorage의 userId 존재 여부만 확인하고 서버 세션을 검증하지 않습니다. BrowserSessionGuard가 이 마커를 신뢰하여 프로필 검증을 건너뛰므로, localStorage의 userId가 유효하더라도 서버 세션이 만료되었다면 인증되지 않은 상태로 진행됩니다.또한 라인 38의 catch 블록에서
logout()API를 호출하지 않고 클라이언트 세션만 정리하므로, 프로필 조회 실패 시 서버 세션이 유지될 수 있습니다. 라인 28-30에서 프로필의 userId가 null이면 세션을 표시하지 않으면서도 라인 31에서 ready를 true로 설정하는 것도 모호한 상태를 만듭니다.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/components/BrowserSessionGuard.jsx` around lines 19 - 25, The guard function currently trusts hasAuthenticatedBrowserSession() (which only checks localStorage) and sets setReady(true) without server validation; change guard to, when hasAuthenticatedBrowserSession() is true, call the profile/session validation endpoint (e.g., fetchProfile or equivalent) to confirm the server session before calling setReady, and if validation fails call logout() to clear both server and client sessions; also update the catch block to invoke logout() on profile fetch errors to avoid leaving a server session active; finally, if the fetched profile has userId === null, clear the client marker and do not call setReady(true) until a valid server-validated profile is returned.src/pages/content/AdminConsolePage.jsx (1)
264-297:⚠️ Potential issue | 🟠 Major
loadGlobalAccessSummary를 deps에서 제거하세요.Line 297의 useEffect에서
loadGlobalAccessSummary를 의존성으로 포함했지만 effect 본문에서는 사용하지 않습니다.loadGlobalAccessSummary는memberSummaryWindowDays에 묶여 있어서 요약 기간을 7일/30일로 전환하면 이 callback이 재생성되고, 결과적으로 전체 페이지 초기화가 불필요하게 다시 실행됩니다.제안 수정
- }, [loadCategories, loadGlobalAccessSummary, loadMembers, loadSets, navigate]); + }, [loadCategories, loadMembers, loadSets, navigate]);🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/pages/content/AdminConsolePage.jsx` around lines 264 - 297, The useEffect that initializes the admin page includes loadGlobalAccessSummary in its dependency array but never uses it in the effect body; remove loadGlobalAccessSummary from the dependency list of that useEffect to prevent unnecessary re-runs when loadGlobalAccessSummary (recreated by memberSummaryWindowDays) changes, keeping only the actually used callbacks (loadCategories, loadMembers, loadSets, navigate) and any other true dependencies referenced inside initialize (e.g., setLoadingPage, setPageErrorMessage if not stable via hooks) to satisfy linter expectations.
🧹 Nitpick comments (7)
index.html (2)
12-12: 브랜드명 대소문자 불일치.
og:title에서는 "VlaInter"를 사용하지만,<title>태그에서는 "vlainter"(소문자)를 사용하고 있습니다. 일관된 브랜딩을 위해 통일하는 것이 좋습니다.🔧 제안된 수정
- <title>vlainter</title> + <title>VlaInter</title>Also applies to: 23-23
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@index.html` at line 12, The og:title meta ("og:title") and the page <title> element use different casing ("VlaInter" vs "vlainter"); update the <title> element and any other occurrences (including the other instance mentioned) to exactly match the brand casing used in the og:title (or vice versa), ensuring both the <title> tag and the meta property="og:title" values are identical (use the same string "VlaInter" across the document).
15-18: OG 이미지 크기가 권장 사양보다 작습니다.Open Graph 이미지는 Facebook, LinkedIn 등에서 최적의 표시를 위해 최소 1200x630 픽셀이 권장됩니다. 현재 484x452 크기의 favicon.png는 소셜 공유 시 작게 표시되거나 잘릴 수 있습니다.
전용 소셜 공유 이미지 사용을 고려해 보세요.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@index.html` around lines 15 - 18, The Open Graph image currently uses a small favicon (meta property="og:image" with og:image:width and og:image:height set to 484x452) which is below the recommended 1200x630; replace the favicon reference with a dedicated social-preview image at least 1200x630, update the meta properties (og:image, og:image:width, og:image:height, og:image:alt) to point to the new asset and correct dimensions, and ensure the alt text (og:image:alt) provides a concise descriptive label for the new social image.src/pages/TermsPage.jsx (1)
114-116:key로 전체 텍스트 대신 인덱스 사용 권장ServiceIntroPage와 동일하게,
line전체 문자열을 key로 사용하면 동일 내용 문단에서 key 충돌이 발생할 수 있습니다.♻️ 제안된 수정
- {body.map((line) => ( - <p key={line}>{line}</p> + {body.map((line, index) => ( + <p key={index}>{line}</p> ))}🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/pages/TermsPage.jsx` around lines 114 - 116, In TermsPage.jsx update the body.map usage to avoid using the entire line string as the React key; change the map callback (body.map((line) => ...)) to accept the index (body.map((line, idx) => ...)) and use that index (or a stable composite key like `${idx}-${line.slice(0,20)}`) for the <p> key prop so identical paragraph texts won't collide.src/pages/PrivacyPolicyPage.jsx (1)
111-116: Section 컴포넌트 중복
Section컴포넌트가TermsPage.jsx와 동일한 구조로 정의되어 있습니다. 공통 컴포넌트로 추출하면 유지보수성이 향상됩니다.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/pages/PrivacyPolicyPage.jsx` around lines 111 - 116, The Section component is duplicated; extract it to a shared component (e.g., export a Section functional component) and replace the local definitions in PrivacyPolicyPage.jsx and TermsPage.jsx with imports. Concretely: create a single Section component file (export default Section) that renders the same structure and classNames, update PrivacyPolicyPage.jsx and TermsPage.jsx to import and use that Section symbol instead of defining it inline, and remove the duplicated Section declarations from both pages.src/pages/ServiceIntroPage.jsx (1)
42-44:key로 전체 텍스트 대신 인덱스 사용 권장
line전체 문자열을 key로 사용하면 동일한 내용의 문단이 있을 경우 key 충돌이 발생합니다.♻️ 제안된 수정
- {body.map((line) => ( - <p key={line}>{line}</p> + {body.map((line, index) => ( + <p key={index}>{line}</p> ))}🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/pages/ServiceIntroPage.jsx` around lines 42 - 44, The current body.map((line) => (<p key={line}>{line}</p>)) uses the full line text as the React key which can collide for identical paragraphs; update the mapping in ServiceIntroPage.jsx to use the index (or a stable unique id if available) as the key, e.g. map((line, idx) => <p key={idx}>{line}</p>), or better yet use a unique identifier when one exists instead of the line string to avoid key collisions.src/components/ResumeSessionModal.jsx (2)
14-15: 백드롭 클릭 핸들러 누락
<div className="absolute inset-0" />가 백드롭 역할을 하는 것 같지만onClick핸들러가 없습니다. 사용자가 모달 외부를 클릭해도 닫히지 않습니다.♻️ 백드롭 클릭 시 모달 닫기 추가
- <div className="absolute inset-0" /> + <div className="absolute inset-0" onClick={onDismiss} aria-hidden="true" />🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/components/ResumeSessionModal.jsx` around lines 14 - 15, The backdrop div in ResumeSessionModal.jsx (the element rendered as <div className="absolute inset-0" />) lacks an onClick handler so clicking outside the modal doesn't close it; add an onClick that calls the component's close handler (use the existing prop or state handler, e.g., onClose or closeModal) and also add e.stopPropagation() on the modal content container (the centered wrapper with class "fixed inset-0 z-[95] flex items-center justify-center bg-black/45 px-4" or its immediate child) to prevent clicks inside the modal from bubbling to the backdrop.
1-50: 포커스 트랩 고려모달이 열렸을 때 키보드 사용자가 Tab으로 모달 외부로 이동할 수 있습니다. 접근성 향상을 위해 포커스 트랩 구현을 고려해 보세요.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/components/ResumeSessionModal.jsx` around lines 1 - 50, When ResumeSessionModal opens (open prop true) keyboard users can Tab out of the dialog; add a focus trap: give the dialog container (the element with role="dialog") a ref inside ResumeSessionModal, on open save document.activeElement, move focus to the first focusable element (e.g., the dismiss or continue buttons), and register a keydown handler that intercepts Tab/Shift+Tab to cycle focus among tabbable elements in the dialog (use a tabbable selector like 'a, button, input, textarea, select, [tabindex]:not([tabindex="-1"])'), and on close restore the previously focused element; implement cleanup in useEffect and ensure disabled/busy state is respected so focus skips disabled controls and onDismiss/onContinue remain unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/components/BrowserSessionGuard.jsx`:
- Around line 27-36: The try block should validate that extractProfile(payload)
yields a profile.userId before marking the session or flipping ready; change the
logic so you only call markAuthenticatedBrowserSession(profile.userId) and
setReady(true) when profile?.userId != null, and when userId is missing do not
setReady(true) (leave ready false or explicitly clear the authenticated state);
adjust the code around getMyProfile, extractProfile,
markAuthenticatedBrowserSession, setReady and cancelled so children are not
rendered when no userId is present (optionally call your session-clear function
if one exists).
- Around line 37-39: The catch block in BrowserSessionGuard.jsx only calls
clearAuthenticatedBrowserSession(), leaving the server session intact; update
the catch to call the logout() function from src/lib/authApi.js (awaiting it if
the surrounding function is async), handle any errors from logout gracefully
(e.g., try/catch or .catch()) and then call clearAuthenticatedBrowserSession()
so both server and client sessions are cleared; reference the existing
clearAuthenticatedBrowserSession() and the logout() export when making this
change.
In `@src/lib/interviewApi.js`:
- Around line 129-132: The dismissTechSession POST should not be auto-retried on
401: update dismissTechSession to call apiRequest with an options object that
includes retryOnUnauthorized: false (e.g., apiRequest(..., { method: "POST",
retryOnUnauthorized: false })). Do the same change for the other dismiss POST in
this file (the other dismiss* function that sends a session-dismiss POST) so
non-idempotent session-dismiss endpoints are excluded from automatic 401
retries.
In `@src/pages/content/AdminConsolePage.jsx`:
- Around line 209-224: The render crashes because
memberGlobalSummary.dailyMetrics can be undefined; normalize the API payload
before storing it (in loadGlobalAccessSummary) or consistently guard every .map
call. Modify loadGlobalAccessSummary to ensure the payload passed to
setMemberGlobalSummary always includes dailyMetrics: default to an empty array
(e.g., ensure payload.dailyMetrics = payload.dailyMetrics || []) before calling
setMemberGlobalSummary, and/or update all usages that call
memberGlobalSummary.dailyMetrics.map(...) to use
(memberGlobalSummary.dailyMetrics || []).map(...); reference functions/vars:
loadGlobalAccessSummary, setMemberGlobalSummary, memberGlobalSummary, and
dailyMetrics.
- Around line 1140-1227: The issue: selectedMemberDetail.accessSummary,
accessSummary.dailyLoginCounts and selectedMemberDetail.recentAccessLogs are
accessed directly causing runtime errors when the API returns partial data; fix
by normalizing these fields before rendering (provide defaults) and use the
existing formatDecimal utility for number formatting. Specifically, ensure
selectedMemberDetail.accessSummary is a safe object (with numeric defaults for
recentLoginCount, activeSessionCount, totalActionCount, averageActionCount,
averageSessionMinutes, interviewCompletionRate, completedInterviewCount,
totalInterviewCount, lastLoginAt, lastLoginIpAddress, calculatedAt and an array
default for dailyLoginCounts) and that selectedMemberDetail.recentAccessLogs
defaults to an empty array; replace direct .toFixed calls with
formatDecimal(selectedMemberDetail.accessSummary.averageActionCount, 1) and
guard .map/.length usage (or use safe empty arrays) when rendering
dailyLoginCounts and recentAccessLogs so the UI never calls
.map/.toFixed/.length on undefined.
In `@src/pages/content/MyPage.jsx`:
- Around line 379-381: The delete flow can still be invoked multiple times
because setDeleteAccountSubmitting(true) is async; add a synchronous guard
(e.g., a module/local ref like isDeletingRef) that you check at the start of the
handler and set to true immediately before awaiting anything, then call
setDeleteAccountSubmitting(true) and run deleteMyAccount(), finally reset both
the ref and setDeleteAccountSubmitting(false) in finally; update the handler
that references deleteMyAccount, setDeleteAccountSubmitting,
deleteAccountErrorMessage and setShowDeleteAccountModal, and apply the same
ref-guard pattern to the other delete flow instance mentioned (lines ~659-672).
- Around line 663-667: After successfully awaiting deleteMyAccount(), call the
existing logout() flow (which already performs
clearAuthenticatedBrowserSession() and resetMyProfileCache()) to ensure
server-side session/cookie invalidation is invoked; replace or remove the direct
calls to clearAuthenticatedBrowserSession() and resetMyProfileCache() so the
code uses await logout() prior to setShowDeleteAccountModal(false) and
navigate("/login", { replace: true }) to avoid leaving server sessions active.
---
Outside diff comments:
In `@src/components/BrowserSessionGuard.jsx`:
- Around line 19-25: The guard function currently trusts
hasAuthenticatedBrowserSession() (which only checks localStorage) and sets
setReady(true) without server validation; change guard to, when
hasAuthenticatedBrowserSession() is true, call the profile/session validation
endpoint (e.g., fetchProfile or equivalent) to confirm the server session before
calling setReady, and if validation fails call logout() to clear both server and
client sessions; also update the catch block to invoke logout() on profile fetch
errors to avoid leaving a server session active; finally, if the fetched profile
has userId === null, clear the client marker and do not call setReady(true)
until a valid server-validated profile is returned.
In `@src/lib/apiClient.js`:
- Around line 37-49: The current default retryOnUnauthorized behavior in
apiClient (variable retryOnUnauthorized used around executeJsonRequest and
refreshAuthSession) enables automatic 401 retry for all methods and risks
double-executing non-idempotent actions; fix by making retryOnUnauthorized false
for unsafe HTTP verbs or explicitly disabling it on non-idempotent callers:
either change the default logic so retryOnUnauthorized defaults to false for
methods other than GET/HEAD/OPTIONS (inspect options.method before setting
retryOnUnauthorized) or update callers like dismissTechSession and
dismissMockSession in interviewApi to pass retryOnUnauthorized: false when
calling the API, ensuring executeJsonRequest/refreshAuthSession flow will not
auto-retry those POST state-changing requests.
In `@src/pages/content/AdminConsolePage.jsx`:
- Around line 264-297: The useEffect that initializes the admin page includes
loadGlobalAccessSummary in its dependency array but never uses it in the effect
body; remove loadGlobalAccessSummary from the dependency list of that useEffect
to prevent unnecessary re-runs when loadGlobalAccessSummary (recreated by
memberSummaryWindowDays) changes, keeping only the actually used callbacks
(loadCategories, loadMembers, loadSets, navigate) and any other true
dependencies referenced inside initialize (e.g., setLoadingPage,
setPageErrorMessage if not stable via hooks) to satisfy linter expectations.
---
Nitpick comments:
In `@index.html`:
- Line 12: The og:title meta ("og:title") and the page <title> element use
different casing ("VlaInter" vs "vlainter"); update the <title> element and any
other occurrences (including the other instance mentioned) to exactly match the
brand casing used in the og:title (or vice versa), ensuring both the <title> tag
and the meta property="og:title" values are identical (use the same string
"VlaInter" across the document).
- Around line 15-18: The Open Graph image currently uses a small favicon (meta
property="og:image" with og:image:width and og:image:height set to 484x452)
which is below the recommended 1200x630; replace the favicon reference with a
dedicated social-preview image at least 1200x630, update the meta properties
(og:image, og:image:width, og:image:height, og:image:alt) to point to the new
asset and correct dimensions, and ensure the alt text (og:image:alt) provides a
concise descriptive label for the new social image.
In `@src/components/ResumeSessionModal.jsx`:
- Around line 14-15: The backdrop div in ResumeSessionModal.jsx (the element
rendered as <div className="absolute inset-0" />) lacks an onClick handler so
clicking outside the modal doesn't close it; add an onClick that calls the
component's close handler (use the existing prop or state handler, e.g., onClose
or closeModal) and also add e.stopPropagation() on the modal content container
(the centered wrapper with class "fixed inset-0 z-[95] flex items-center
justify-center bg-black/45 px-4" or its immediate child) to prevent clicks
inside the modal from bubbling to the backdrop.
- Around line 1-50: When ResumeSessionModal opens (open prop true) keyboard
users can Tab out of the dialog; add a focus trap: give the dialog container
(the element with role="dialog") a ref inside ResumeSessionModal, on open save
document.activeElement, move focus to the first focusable element (e.g., the
dismiss or continue buttons), and register a keydown handler that intercepts
Tab/Shift+Tab to cycle focus among tabbable elements in the dialog (use a
tabbable selector like 'a, button, input, textarea, select,
[tabindex]:not([tabindex="-1"])'), and on close restore the previously focused
element; implement cleanup in useEffect and ensure disabled/busy state is
respected so focus skips disabled controls and onDismiss/onContinue remain
unchanged.
In `@src/pages/PrivacyPolicyPage.jsx`:
- Around line 111-116: The Section component is duplicated; extract it to a
shared component (e.g., export a Section functional component) and replace the
local definitions in PrivacyPolicyPage.jsx and TermsPage.jsx with imports.
Concretely: create a single Section component file (export default Section) that
renders the same structure and classNames, update PrivacyPolicyPage.jsx and
TermsPage.jsx to import and use that Section symbol instead of defining it
inline, and remove the duplicated Section declarations from both pages.
In `@src/pages/ServiceIntroPage.jsx`:
- Around line 42-44: The current body.map((line) => (<p key={line}>{line}</p>))
uses the full line text as the React key which can collide for identical
paragraphs; update the mapping in ServiceIntroPage.jsx to use the index (or a
stable unique id if available) as the key, e.g. map((line, idx) => <p
key={idx}>{line}</p>), or better yet use a unique identifier when one exists
instead of the line string to avoid key collisions.
In `@src/pages/TermsPage.jsx`:
- Around line 114-116: In TermsPage.jsx update the body.map usage to avoid using
the entire line string as the React key; change the map callback
(body.map((line) => ...)) to accept the index (body.map((line, idx) => ...)) and
use that index (or a stable composite key like `${idx}-${line.slice(0,20)}`) for
the <p> key prop so identical paragraph texts won't collide.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 50695418-2dd4-4839-bbc1-cad5ec3e2898
📒 Files selected for processing (24)
index.htmlsrc/App.jsxsrc/components/AuthFooter.jsxsrc/components/BrowserSessionGuard.jsxsrc/components/LegalDocumentLayout.jsxsrc/components/ResumeSessionModal.jsxsrc/components/TopNav.jsxsrc/lib/adminApi.jssrc/lib/apiClient.jssrc/lib/interviewApi.jssrc/lib/resumeInterviewSession.jssrc/lib/userApi.jssrc/pages/PrivacyPolicyPage.jsxsrc/pages/ServiceIntroPage.jsxsrc/pages/StartingPage.jsxsrc/pages/TermsPage.jsxsrc/pages/auth/ForgotPassword.jsxsrc/pages/auth/Join.jsxsrc/pages/auth/Login.jsxsrc/pages/content/AdminConsolePage.jsxsrc/pages/content/InterviewStartPage.jsxsrc/pages/content/MyPage.jsxsrc/pages/content/QuestionSetsPage.jsxsrc/pages/content/TechPracticePage.jsx
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 이 풀 리퀘스트는 사용자 경험을 향상시키고 관리 기능을 확장하는 중요한 업데이트를 포함합니다. 이용약관, 개인정보처리방침, 서비스 소개 페이지를 추가하여 서비스의 투명성을 높였으며, 중단된 면접 세션을 재개할 수 있는 기능을 도입하여 사용자의 편의성을 크게 개선했습니다. 또한, 회원 탈퇴 기능을 제공하고 회원가입 시 약관 동의를 필수화하여 사용자 관리 및 규정 준수를 강화했습니다. 관리자 콘솔에는 회원 접속 통계와 검색 기능이 추가되어 운영 효율성이 증대되었습니다. 전반적으로 서비스의 안정성과 사용성을 높이는 데 중점을 두었습니다. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
| canRetryUnauthorized && | ||
| path !== "/api/auth/refresh" | ||
| ) { | ||
| if (response.status === 401 && retryOnUnauthorized && path !== "/api/auth/refresh") { |
There was a problem hiding this comment.
401 응답 시 모든 HTTP 메서드에 대해 재시도를 하도록 변경되었는데, 이는 위험할 수 있습니다. POST, PATCH, DELETE와 같이 멱등성(idempotent)이 보장되지 않는 요청을 재시도할 경우, 리소스가 중복 생성되거나 원치 않는 부작용이 발생할 수 있습니다.
예를 들어, 사용자가 회원 탈퇴(DELETE /api/users/me)를 요청했는데 네트워크 문제로 응답을 받지 못하고 세션이 만료된 경우, 재로그인 후 탈퇴 요청이 재시도되어 이미 삭제된 계정을 다시 삭제하려는 시도가 발생할 수 있습니다.
안전한 GET, HEAD, OPTIONS 메서드에 대해서만 재시도를 허용했던 이전 로직으로 되돌리는 것을 권장합니다. 아래 제안된 if문과 함께, if문 앞에 다음 변수들을 다시 추가해주세요:
const method = String(options.method || "GET").toUpperCase();
const safeRetryMethods = new Set(["GET", "HEAD", "OPTIONS"]);
const canRetryUnauthorized = retryOnUnauthorizedOption === true || safeRetryMethods.has(method); if (
response.status === 401 &&
retryOnUnauthorized &&
canRetryUnauthorized &&
path !== "/api/auth/refresh"
) {
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9e177a3abc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| await restoreAdminMember(selectedMemberId); | ||
| const refreshed = await getAdminMemberDetail(selectedMemberId); | ||
| setSelectedMemberDetail(normalizeMemberDetail(refreshed)); | ||
| await loadMembers(memberPage); |
There was a problem hiding this comment.
After restoring a soft-deleted member, the list reload uses loadMembers(memberPage) without the active memberKeyword, so any filtered view is dropped and the admin is unexpectedly moved back to the unfiltered dataset. This is reproducible whenever restore is triggered from a keyword search result; pass the current keyword to keep pagination/selection consistent with the user’s current context.
Useful? React with 👍 / 👎.
| setDeleteAccountErrorMessage(""); | ||
| try { | ||
| await deleteMyAccount(); | ||
| await logout(); |
There was a problem hiding this comment.
Account deletion and logout are chained in one try, so if deleteMyAccount() succeeds but logout() fails (e.g., transient network/server error), the catch path reports full deletion failure and leaves the user on My Page despite the account already being removed. This creates a broken post-deletion UX; after successful deletion, the client should still close the modal and redirect to /login even if logout throws.
Useful? React with 👍 / 👎.
1 participant
Summary by CodeRabbit
새로운 기능
개선