Add pylint

Author: rkhwaja

.travis.yml

@@ -6,6 +6,7 @@ dist: xenial
 install:
 - pip install fs sqlalchemy pytest python-coveralls coverage
 script:
+- pylint src/sqliteupload
 - coverage run --source . -m pytest
 - coverage report --omit */Lib/*,tests/*
 - coverage html --omit */Lib/*,tests/*

README.md

@@ -1,8 +1,6 @@
 # sqlalchemy-sqliteupload
 
-[![Build Status](https://travis-ci.org/rkhwaja/sqlalchemy-sqliteupload.svg?branch=master)](https://travis-ci.org/rkhwaja/sqlalchemy-sqliteupload)
-
-[![Coverage Status](https://coveralls.io/repos/github/rkhwaja/sqlalchemy-sqliteupload/badge.svg?branch=master)](https://coveralls.io/github/rkhwaja/sqlalchemy-sqliteupload?branch=master)
+[![Build Status](https://travis-ci.org/rkhwaja/sqlalchemy-sqliteupload.svg?branch=master)](https://travis-ci.org/rkhwaja/sqlalchemy-sqliteupload) [![Coverage Status](https://coveralls.io/repos/github/rkhwaja/sqlalchemy-sqliteupload/badge.svg?branch=master)](https://coveralls.io/github/rkhwaja/sqlalchemy-sqliteupload?branch=master)
 
 Based on [sqlalchemy-s3sqlite](//github.com/cariaso/sqlalchemy-s3sqlite)
 

pylintrc

@@ -0,0 +1,7 @@
+[FORMAT]
+indent-string=\t
+max-line-length=200
+
+[MESSAGES CONTROL]
+# no-member causes false positives with objects constructed via google's discovery protocol
+disable=bad-continuation, fixme, invalid-name, len-as-condition, missing-docstring, no-member

pyproject.toml

@@ -11,6 +11,7 @@ fs = "^2.4"
 
 [tool.poetry.dev-dependencies]
 pytest = "^3.0"
+pylint = "^2.3"
 
 [build-system]
 requires = ["poetry>=0.12"]

src/sqliteupload/dialect.py

@@ -1,7 +1,6 @@
 from contextlib import suppress
 from hashlib import md5
-from io import BytesIO
-from logging import debug, info
+from logging import debug
 from os import close, remove
 from tempfile import mkstemp
 
@@ -15,16 +14,18 @@ def _hash_of_bytes(bytes_):
 	hash_.update(bytes_)
 	return hash_.hexdigest()
 
-class SQLiteUploadDialect(SQLiteDialect_pysqlite):
+class SQLiteUploadDialect(SQLiteDialect_pysqlite): # pylint: disable=abstract-method
 
 	def __init__(self, *args, **kw):
 		super().__init__(*args, **kw)
 		handle, self._localPath = mkstemp()
 		close(handle)
 		self._localHash = None
 		debug(f"localPath: {self._localPath}")
+		self._remoteFilename = None
+		self._fs = None
 
-	def close(self, *args, **kwargs):
+	def close(self, *args, **kwargs): # pylint: disable=unused-argument
 		with open(self._localPath, "rb") as f:
 			bytes_ = f.read()
 
@@ -40,8 +41,8 @@ def connect(self, *args, **kw):
 		self._load_remote_db(uploadUrl)
 		return super().connect(self._localPath, **kw)
 
-	def do_close(self, *args, **kw):
-		out = super().do_close(*args, **kw)
+	def do_close(self, dbapi_connection):
+		out = super().do_close(dbapi_connection)
 		self.close()
 		return out
 
@@ -50,7 +51,7 @@ def _load_remote_db(self, remotePath):
 		fsurl = remotePath[:lastSeparator]
 		self._remoteFilename = remotePath[lastSeparator + 1:]
 		self._fs = open_fs(fsurl)
-		
+
 		try:
 			remoteBytes = self._fs.readbytes(self._remoteFilename)
 			with open(self._localPath, "wb") as localFile: # truncate any existing files
@@ -63,7 +64,8 @@ def _load_remote_db(self, remotePath):
 				remove(self._localPath)
 			self._localHash = None
 
-urlScheme = "sqliteupload"
-
 def RegisterDialect():
-	registry.register(urlScheme, "sqliteupload.dialect", SQLiteUploadDialect.__name__)
+	registry.register(
+		name="sqliteupload",
+		modulepath="sqliteupload.dialect",
+		objname=SQLiteUploadDialect.__name__)