Conversation
|
🚅 Deployed to the rivet-pr-4646 environment in rivet-frontend
|
|
PR Review: feat(frontend): remove plain - Summary - This PR removes the Plain live chat integration from the frontend. It also bundles Graphite skill infrastructure changes and Docker envoy-protocol additions. The core work (Plain removal) is clean. Issues noted below. Frontend Changes (Plain Removal): Clean execution across all affected files. vite.engine.config.ts: liveChatPlugin function/export and unused Plugin type import removed. vite.cloud.config.ts: liveChatPlugin import gone; plugins:[] is correct since engineConfig supplies its own via mergeConfig. vite-env.d.ts: Plain global interface fully removed. help-dropdown.tsx: Live Chat item and faComments import cleanly stripped. waitForClerk.ts: Commented-out Plain setCustomerDetails code removed (good dead code cleanup). onboarding/footer.tsx: match(APP_TYPE) branch and ts-pattern import replaced with a single Feedback button. Note: cloud users previously had a Support button that opened Plain chat; they now get the same feedback modal as non-cloud users - confirm this UX change is intentional. index.html: live_chat placeholder removed. No residual Plain references found - removal is complete. Issues:
Minor: Good cleanup of the graphite-is-being-a-piece-of-shit-just-merge-my-stack symlink. The new .agents/skills/graphite/SKILL.md is thorough and well-structured. Verdict: The Plain removal is clean and complete. Main asks: fill in the PR description with motivation, and explain the Docker envoy-protocol addition (or split it into its own PR). |
aa52da6 to
4fc3d84
Compare
Preview packages published to npmInstall with: npm install rivetkit@pr-4646All packages published as Engine binary is shipped via Docker images: docker pull rivetdev/engine:slim-7b563ef
docker pull rivetdev/engine:full-7b563efIndividual packagesnpm install rivetkit@pr-4646
npm install @rivetkit/react@pr-4646
npm install @rivetkit/rivetkit-native@pr-4646
npm install @rivetkit/sqlite-wasm@pr-4646
npm install @rivetkit/workflow-engine@pr-4646 |

Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: