Skip to content

feat(frontend): remove plain#4646

Merged
jog1t merged 1 commit intomainfrom
04-13-feat_frontend_remove_plain
Apr 13, 2026
Merged

feat(frontend): remove plain#4646
jog1t merged 1 commit intomainfrom
04-13-feat_frontend_remove_plain

Conversation

@jog1t
Copy link
Copy Markdown
Contributor

@jog1t jog1t commented Apr 13, 2026

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@railway-app
Copy link
Copy Markdown

railway-app bot commented Apr 13, 2026

🚅 Deployed to the rivet-pr-4646 environment in rivet-frontend

Service Status Web Updated (UTC)
frontend-inspector ✅ Success (View Logs) Web Apr 13, 2026 at 2:38 pm
frontend-cloud ✅ Success (View Logs) Web Apr 13, 2026 at 2:37 pm
website 😴 Sleeping (View Logs) Web Apr 13, 2026 at 2:37 pm
ladle ❌ Build Failed (View Logs) Web Apr 13, 2026 at 2:35 pm
kitchen-sink ❌ Build Failed (View Logs) Web Apr 13, 2026 at 2:34 pm
mcp-hub ✅ Success (View Logs) Web Apr 13, 2026 at 2:27 pm

@railway-app railway-app bot temporarily deployed to rivet-frontend / rivet-pr-4646 April 13, 2026 14:26 Destroyed
Copy link
Copy Markdown
Contributor Author

jog1t commented Apr 13, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@jog1t jog1t marked this pull request as ready for review April 13, 2026 14:28
@claude
Copy link
Copy Markdown

claude bot commented Apr 13, 2026

PR Review: feat(frontend): remove plain - Summary - This PR removes the Plain live chat integration from the frontend. It also bundles Graphite skill infrastructure changes and Docker envoy-protocol additions. The core work (Plain removal) is clean. Issues noted below.

Frontend Changes (Plain Removal): Clean execution across all affected files. vite.engine.config.ts: liveChatPlugin function/export and unused Plugin type import removed. vite.cloud.config.ts: liveChatPlugin import gone; plugins:[] is correct since engineConfig supplies its own via mergeConfig. vite-env.d.ts: Plain global interface fully removed. help-dropdown.tsx: Live Chat item and faComments import cleanly stripped. waitForClerk.ts: Commented-out Plain setCustomerDetails code removed (good dead code cleanup). onboarding/footer.tsx: match(APP_TYPE) branch and ts-pattern import replaced with a single Feedback button. Note: cloud users previously had a Support button that opened Plain chat; they now get the same feedback modal as non-cloud users - confirm this UX change is intentional. index.html: live_chat placeholder removed. No residual Plain references found - removal is complete.

Issues:

  1. PR description is empty. The template checklist was not filled in. A brief note on motivation (e.g. removing Plain as a support channel) would help reviewers and git log context.

  2. Unrelated changes bundled together. This PR mixes three distinct concerns: (a) Plain removal, (b) adding envoy-protocol SDK to Dockerfiles, (c) Graphite skill reorganization. Per the project atomic PR guidelines these should ideally be separate PRs.

  3. Docker envoy-protocol addition needs justification. All three Dockerfiles (cloud.Dockerfile, inspector.Dockerfile, ladle.Dockerfile) add: COPY engine/sdks/typescript/envoy-protocol/ engine/sdks/typescript/envoy-protocol/ This is unrelated to Plain removal and is unmentioned in the PR title/description. What prompted it?

  4. skills-lock.json third-party source. The new lock file references withgraphite/agent-skills from GitHub. Confirm the computedHash is verified at install time and the source is pinned to mitigate supply chain risk.

Minor: Good cleanup of the graphite-is-being-a-piece-of-shit-just-merge-my-stack symlink. The new .agents/skills/graphite/SKILL.md is thorough and well-structured.

Verdict: The Plain removal is clean and complete. Main asks: fill in the PR description with motivation, and explain the Docker envoy-protocol addition (or split it into its own PR).

@jog1t jog1t force-pushed the 04-13-feat_frontend_remove_plain branch from aa52da6 to 4fc3d84 Compare April 13, 2026 14:34
@railway-app railway-app bot temporarily deployed to rivet-frontend / rivet-pr-4646 April 13, 2026 14:34 Destroyed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 13, 2026

Preview packages published to npm

Install with:

npm install rivetkit@pr-4646

All packages published as 0.0.0-pr.4646.7b563ef with tag pr-4646.

Engine binary is shipped via @rivetkit/engine-cli on linux-x64-musl, linux-arm64-musl, darwin-x64, and darwin-arm64. Windows users should use the release installer or set RIVET_ENGINE_BINARY.

Docker images:

docker pull rivetdev/engine:slim-7b563ef
docker pull rivetdev/engine:full-7b563ef
Individual packages
npm install rivetkit@pr-4646
npm install @rivetkit/react@pr-4646
npm install @rivetkit/rivetkit-native@pr-4646
npm install @rivetkit/sqlite-wasm@pr-4646
npm install @rivetkit/workflow-engine@pr-4646

Copy link
Copy Markdown
Contributor Author

jog1t commented Apr 13, 2026

Merge activity

  • Apr 13, 2:41 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Apr 13, 2:41 PM UTC: @jog1t merged this pull request with Graphite.

@jog1t jog1t merged commit 31c444e into main Apr 13, 2026
26 of 33 checks passed
@jog1t jog1t deleted the 04-13-feat_frontend_remove_plain branch April 13, 2026 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant