Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: alter shared source fresh schema will make it non-shared #19802

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: alter shared source fresh schema will make it non-shared #19802

wants to merge 1 commit into from
+134 −54

Conversation

xxchan
Copy link
Member

@xxchan xxchan commented Dec 14, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

fix #19799

Note: This problem only exists for REFRESH SCHEMA (i.e., source with schema regitry), but not for ADD COLUMN, because only the former updated source_info

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • My PR contains critical fixes that are necessary to be merged into the latest release.

Documentation

  • My PR needs documentation updates.
Release note

@xxchan
fix: alter shared source fresh schema will make it non-shared
c3bad94 
fix #19799

Note: This problem only exists for `REFRESH SCHEMA` (i.e., source with schema regitry), but not for `ADD COLUMN`, because only the former updated `source_info`
Signed-off-by: xxchan <[email protected]>
@github-actions github-actions bot added the type/fix Bug fix label Dec 14, 2024
@xxchan xxchan marked this pull request as ready for review December 14, 2024 03:53
@graphite-app graphite-app bot requested a review from a team December 14, 2024 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiangjinwu xiangjinwu Awaiting requested review from xiangjinwu

@BugenZhao BugenZhao Awaiting requested review from BugenZhao

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
type/fix Bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Alter shared source will make it non-shared
1 participant
@xxchan