Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

broken links for tor / onion services in footer #830

Closed
mfc opened this issue Jun 5, 2024 · 0 comments · Fixed by #831
Closed

broken links for tor / onion services in footer #830

mfc opened this issue Jun 5, 2024 · 0 comments · Fixed by #831

Comments

@mfc
Copy link

mfc commented Jun 5, 2024

hi all,

the footers added via this merge create a url based on the currently viewed page, so if someone clicks the link outside of the main page it will be broken.

for example, if the user is on the following page:
https://riseup.net/en/email/settings

the footer links created are:
https://riseup.net/en/email/settings/security/network-security/tor#riseups-tor-onion-services

and
https://riseup.net/en/email/settings/email/settings/tor

(notice the addition of the page where you are visiting from to the url, which breaks the links.)

this could be solved by having the links in the footer be direct links rather than relative links.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant