Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve eviction and expiration of labeled metrics #46

Open
devromik opened this issue May 15, 2023 · 0 comments
Open

Improve eviction and expiration of labeled metrics #46

devromik opened this issue May 15, 2023 · 0 comments
Milestone

Comments

@devromik
Copy link
Collaborator

devromik commented May 15, 2023

  1. AbstractMeter: order MetricInstances within the same millisecond based on their insertion order.
  2. Provide CompletableFuture<Iterator> iterator(Executor completionExecutor) to return iterator after removeExpiredInstances(). Update exporters accordingly.
  3. Make periodic actualisation (removeExpiredInstancesAndSchedule) of MetricInstances optional.
  4. Consider eliminating EXPIRED_INSTANCES_REMOVAL_ADDITIONAL_DELAY_MS in
    executor.schedule(
    this::removeExpiredInstancesAndSchedule,
    baseDelayMs + EXPIRED_INSTANCES_REMOVAL_ADDITIONAL_DELAY_MS, MILLISECONDS);

Consider min(baseDelayMs, 10000)

@devromik devromik added this to the 4.0 milestone May 15, 2023
@devromik devromik modified the milestones: 4.0, 4.1 Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant