Merge pull request #540 from eerohele/warn-on-reflection

Enable reflection warnings globally and fix reflection warnings in tests

Author: weavejester

ring-bench/project.clj

@@ -9,4 +9,5 @@
                  [ring/ring-jetty-adapter "1.15.2"]
                  [ring/ring-servlet "1.15.2"]]
   :jvm-opts {}
-  :main ring.bench.servlet)
+  :main ring.bench.servlet
+  :global-vars {*warn-on-reflection* true})

ring-core-protocols/project.clj

@@ -6,4 +6,5 @@
             :url "http://opensource.org/licenses/MIT"}
   :dependencies []
   :profiles
-  {:dev {:dependencies [[org.clojure/clojure "1.9.0"]]}})
+  {:dev {:dependencies [[org.clojure/clojure "1.9.0"]]}}
+  :global-vars {*warn-on-reflection* true})

ring-core/project.clj

@@ -17,4 +17,5 @@
   {:dev  {:dependencies [[clj-time "0.15.2"]]}
    :1.10 {:dependencies [[org.clojure/clojure "1.10.3"]]}
    :1.11 {:dependencies [[org.clojure/clojure "1.11.4"]]}
-   :1.12 {:dependencies [[org.clojure/clojure "1.12.1"]]}})
+   :1.12 {:dependencies [[org.clojure/clojure "1.12.1"]]}}
+  :global-vars {*warn-on-reflection* true})

ring-core/test/ring/middleware/multipart_params/test/byte_array.clj

@@ -11,4 +11,4 @@
                  :stream (string-input-stream "foo")})]
     (is (= (:filename result) "foo.txt"))
     (is (= (:content-type result) "text/plain"))
-    (is (= (String. (:bytes result)) "foo"))))
+    (is (= (String. ^bytes (:bytes result)) "foo"))))

ring-core/test/ring/middleware/multipart_params/test/request_context.clj

@@ -1,7 +1,8 @@
 (ns ring.middleware.multipart-params.test.request-context
   (:require [clojure.test :refer :all]
-            [ring.middleware.multipart-params :as mp]))
+            [ring.middleware.multipart-params :as mp])
+  (:import [org.apache.commons.fileupload2.core RequestContext]))
 
 (deftest test-default-content-length
   (is (= -1
-         (.getContentLength (#'mp/request-context {} nil)))))
+         (.getContentLength ^RequestContext (#'mp/request-context {} nil)))))

ring-core/test/ring/middleware/multipart_params/test/temp_file.clj

@@ -1,7 +1,8 @@
 (ns ring.middleware.multipart-params.test.temp-file
   (:require [clojure.test :refer :all]
             [ring.middleware.multipart-params.temp-file :refer :all]
-            [ring.util.io :refer [string-input-stream]]))
+            [ring.util.io :refer [string-input-stream]])
+  (:import [java.io File]))
 
 (deftest test-temp-file-store
   (let [store  (temp-file-store)
@@ -12,11 +13,11 @@
     (is (= (:filename result) "foo.txt"))
     (is (= (:content-type result) "text/plain"))
     (is (= (:size result) 3))
-    (is (instance? java.io.File (:tempfile result)))
-    (is (.exists (:tempfile result)))
+    (is (instance? File (:tempfile result)))
+    (is (.exists ^File (:tempfile result)))
     (is (= (slurp (:tempfile result)) "foo"))))
 
-(defn eventually [check n d]
+(defn eventually [check n ^long d]
   (loop [i n]
     (if (check)
       true
@@ -30,9 +31,9 @@
                 {:filename "foo.txt"
                  :content-type "text/plain"
                  :stream (string-input-stream "foo")})]
-    (is (.exists (:tempfile result)))
+    (is (.exists ^File (:tempfile result)))
     (Thread/sleep 2000)
-    (let [deleted? (eventually #(not (.exists (:tempfile result))) 120 250)]
+    (let [deleted? (eventually #(not (.exists ^File (:tempfile result))) 120 250)]
       (is deleted?))))
 
 (defn all-threads []

ring-core/test/ring/middleware/session/test/cookie.clj

@@ -3,7 +3,9 @@
             [ring.middleware.session.store :refer :all]
             [ring.middleware.session.cookie :as cookie :refer [cookie-store]]
             [ring.util.codec :as codec]
-            [crypto.random :as random]))
+            [crypto.random :as random])
+  (:import [java.io Writer]
+           [java.time Instant]))
 
 (deftest cookie-session-read-not-exist
   (let [store (cookie-store)]
@@ -58,14 +60,14 @@
        (cookie-store {:key (.getBytes "012345678901234567890")}))))
 
 ; setup for serializing/deserializing Instant.
-(defmethod print-method java.time.Instant [dt out]
+(defmethod print-method Instant [^Instant dt ^Writer out]
   (.write out (str "#foo/instant \"" (.toString dt) "\"")))
 
-(defn parse-instant [x] (java.time.Instant/parse x))
+(defn parse-instant [x] (Instant/parse x))
 
 (deftest cookie-session-custom-type
   (let [store    (cookie-store {:readers {'foo/instant #'parse-instant}})
-        now      (java.time.Instant/now)
+        now      (Instant/now)
         sess-key (write-session store nil {:foo now})]
     (is (not (nil? sess-key)))
     (is (= (read-session store sess-key)

ring-core/test/ring/middleware/test/file.clj

@@ -10,9 +10,9 @@
   (is (thrown-with-msg? Exception #".*Directory does not exist.*"
                         (wrap-file (constantly test-response) "not_here"))))
 
-(def public-dir "test/ring/assets")
-(def index-html (File. ^String public-dir "index.html"))
-(def foo-html   (File. ^String public-dir "foo.html"))
+(def ^String public-dir "test/ring/assets")
+(def index-html (File. public-dir "index.html"))
+(def foo-html   (File. public-dir "foo.html"))
 
 (def app (wrap-file (constantly test-response) public-dir))
 

ring-core/test/ring/middleware/test/file_info.clj

@@ -15,10 +15,11 @@
   "Lets us use a known file modification time for tests, without permanently changing
    the file's modification time."
   [[file new-time] form]
-  `(let [old-time# (.lastModified ~file)]
-     (.setLastModified ~file ~(* new-time 1000))
-     (try ~form
-          (finally (.setLastModified ~file old-time#)))))
+  (let [file (vary-meta file assoc :tag `File)]
+    `(let [old-time# (.lastModified ~file)]
+       (.setLastModified ~file ~(* new-time 1000))
+       (try ~form
+         (finally (.setLastModified ~file old-time#))))))
 
 (def custom-type-app
   (wrap-file-info

ring-core/test/ring/middleware/test/multipart_params.clj

@@ -161,7 +161,7 @@
                  :body (string-input-stream form-body)}
         response (handler request)]
     (let [upload (get-in response [:multipart-params "upload"])]
-      (is (java.util.Arrays/equals (:bytes upload) (.getBytes "foo"))))))
+      (is (java.util.Arrays/equals ^bytes (:bytes upload) (.getBytes "foo"))))))
 
 (deftest forced-encoding-option-works
   (let [form-body (str "--XXXX\r\n"