CheckNsignatures done by launchpad is not the same function as the one done with the safe v1.4.1 #15
Description
Have you ensured that all of these are up to date?
- This repo
- Any dependencies (according to the
package.json)
What command(s) is the bug in?
No response
Operating System
None
Describe the bug
Hello guys !
It looks like the verification done in the launchpad using the checkNsignatures is not the same as the one done in the v1.3 and 1.4 version of safe (which to my knowledge are the latest versions that are live)
Here is the verification done in the checkNsignature: https://github.com/rhinestonewtf/checknsignatures/blob/7ff44ef46da1266374e6a98e6cf69d727d7c357d/src/CheckNSignatures.sol#L30
Here is the one on safe v1.4:
https://github.com/safe-global/safe-smart-account/blob/192c7dc67290940fcbc75165522bb86a37187069/contracts/Safe.sol#L274
This affects the contract signature verification (where datahash is send instead of data)
It looks like you guys started with the version that safe have in their main branch, which is not yet "live" as I understand it and probably makes contract signature verification fail for 1.4 and 1.3