Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Periodic effects don't tick correctly when first applied or after paused #80

Open
monodop opened this issue Jun 3, 2024 · 0 comments
Open

Comments

@monodop
Copy link

monodop commented Jun 3, 2024

I had a couple observations while looking at effect periods:

First delayed PeriodTick is incorrect

The first PeriodTick (not including the one called from PeriodTickAtStart) will happen at an arbitrary point between 0 seconds and the defined period depending on what the initial mod value for ActionTimer is. For example: with a period of 10 seconds, the first PeriodTick could occur immediately, at 10 seconds, or anywhere between.

PausePeriodicEffect unexpected behavior

Pausing the period with the PausePeriodicEffect tag does not actually pause the period, it only disables PeriodTicks. Intuitively, it seems like pausing the effect should also pause the timer. For example:

  • With a period tick of 10 seconds:
  • Period tick occurs
  • Wait 1 second
  • PausePeriodicEffect tag applied
  • Wait 1 second
  • PausePeriodicEffect tag removed
  • Period tick should occur after 9 more seconds (currently would fire in 8 seconds)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant