-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Browser friendly npm package #117
Comments
We are using it already in browser. (but only node: {
fs: 'empty',
}, in your webpack config to make it work. |
Where exactly in the webpack.config.js file does that snippet go? I assume it's not on the root of the config object. |
Yes it's on root |
Thank you |
If you want to use only
or
|
I worked on removing the source-map support. This will solve the issue. Trying to reach out to the rework members before going into the fork route (and discussing with my company for the PR route). |
In the browser context, dependencies like
fs
are not necessarily available. Source maps are also not important when the library is used in the browser.Is this something you could consider: Providing a browser-friendly npm package? I'm well aware about the option here https://github.com/reworkcss/css/blob/master/lib/stringify/index.js#L31 but unfortunately, this can't be statically analyzed by bundlers to avoid bundling the source map file entirely.
Any thoughts?
Thanks.
Context: Trying to use this library in Gutenberg (the new WordPress editor) WordPress/gutenberg#9008
The text was updated successfully, but these errors were encountered: