-
-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renaming attachments directly or based on parent items doesn't change betterbibtex json attachment filename #3135
Comments
🤖 this is your friendly neighborhood build bot announcing test build 7.0.5.7584 ("log cache by name") This update may name other issues, but the build just dropped here is for you; it just means problems already fixed in other issues have been folded into the work we are doing here. Install in Zotero by downloading test build 7.0.5.7584, opening the Zotero "Tools" menu, selecting "Add-ons", open the gear menu in the top right, and select "Install Add-on From File...". |
The log did capture an error. New log from build 7584 please. |
Installed: D682467095 I checked the json, the renames didn't happen. |
I did some more testing:
|
These go to Zotero. I have no access to these.
There isn't anything in the Help menu? No Better BibTeX or File.io?
The test build only adds logging, it's not a fix, I don't know what the problem is yet. The errors in
I need to address the existing problem in |
If I click BBT Help or right-click menu to send debug, I have no confirmation that it was sent. I am on blind mode here. Some logs:
I have these settings: Please instruct how to proceed. Cheers |
It's funny, it has renamed the actual attachment (I mean the rename is reflected in the json with automatic save even), but the change in the Title is not picked up. But even Zotero itself is slow to pick up on these changes. I had to open a different app window and come back to see the rename based on parent metadata happen in Zotero itself. Could be in issue with a large sql databases with too much index. I cannot investigate... I tried a second one, this time even the pdf rename was not reflected, but I didn't initiate the rename from metadata, but used manual rename. So it's all haphazard, is all I can say. The one workaround I can do is change citationKey and then either the automatic save will update the renames of filename and title or a manual export. Again pressed log to be sent. No confirmation it was sent. |
Tried again. |
🤖 this is your friendly neighborhood build bot announcing test build 7.0.5.7600 ("cache count failed") This update may name other issues, but the build just dropped here is for you; it just means problems already fixed in other issues have been folded into the work we are doing here. Install in Zotero by downloading test build 7.0.5.7600, opening the Zotero "Tools" menu, selecting "Add-ons", open the gear menu in the top right, and select "Install Add-on From File...". |
this also fixes the debug log submitter |
Sorry, didn't see notifications for this earlier. I had to remove earlier version because the install was not overwriting the old one. Made the drill of renaming parent item, then the PDF and the title property. Debug log: |
You mean you initially had two BBTs installed side by side? |
I think the first tester file was installed to take over the existing one. I don't remember having to remove it...? In the meantime, with the second tester, it didn't want to fit into the Zotero. I think it was me disabling and enabling it that caused the following output:
And:
Then I restarted Zotero 7 again and then the enable of the plugin was successful. Then I didn't bothered with it. If the first tester was installed ALONGSIDE the existing one, I certainly don't remember seeing visual feedback of any such anomaly. If that's what you're asking. |
I don't know what you mean by this. Were two BBTs installed? In what sense didn't it overwrite the installed build? What did you see/experience to make you say "it didn't overwrite"?
This is not good. A new build is incoming, it should report
before the error. I need that line. |
Oh and you need to have debug logging on (in the help menu) before installing the test build, it was off at time of installation in |
🤖 this is your friendly neighborhood build bot announcing test build 7.0.5.7605 ("database is not attaching?") This update may name other issues, but the build just dropped here is for you; it just means problems already fixed in other issues have been folded into the work we are doing here. Install in Zotero by downloading test build 7.0.5.7605, opening the Zotero "Tools" menu, selecting "Add-ons", open the gear menu in the top right, and select "Install Add-on From File...". |
As I said I don't think two BBTs were installed, as I have only three more extensions, Add-on Market, ZotMoov and Actions&Tags installed and if I had visual notification of two BBTs next to each other among the extensions, I would have easily seen it but of course I don't remember anything now. Although it must be said, we average users don't know if we install a second instance of the same extension, how Zotero will handle it. I have removed the 2nd tester or whatever with 7600 suffix and installed this new one with 7605 AFTER enabling logging. I have this before sending:
Debug log ID: |
🤖 this is your friendly neighborhood build bot announcing test build 7.0.5.7606 ("more logging") This update may name other issues, but the build just dropped here is for you; it just means problems already fixed in other issues have been folded into the work we are doing here. Install in Zotero by downloading test build 7.0.5.7606, opening the Zotero "Tools" menu, selecting "Add-ons", open the gear menu in the top right, and select "Install Add-on From File...". |
By overwrite I meant what I wrote above: you have something that is essentially the same thing (app, plugin, etc.) as you have had before, in our case: the BBT plugin. If you install another of the same thing, would Zotero allow two of the same thing? I don't think so (I don't want to try now), so the new version would be expected (by me) to overwrite the previous version of the same thing, the plugin. That can be called an overwrite, no? Screencast: Didn't bother to check the json as I know you are not sending a fix yet. But I still go ahead to apply my workaround. Debug ID sent: |
No, it doesn't, but it's the only way I could make sense of what you're saying. It's technically possible if I somehow gave it a different internal ID, which I didn't.
Yes, which is what Zotero always does, so in what sense did it not do that? I still don't understand how you came to the conclusion that "it did not overwrite". This is supposed to be impossible, and could point to a deeper problem in Zotero, so I'm trying to understand what's going on. |
Please do this after sending the debug log. I don't want this in the log, because it could mask the problem of an event not being handled. |
When you say "no changes in the PDF", you mean "no changes in the path in the JSON that points to the PDF", right? Automatic exports don't do attachment export.
For an auto-export? According to |
Or do you mean Zotero would not allow you to install the replacement xpi until you removed the existing install? If that's the case you'd need to take that up with Zotero. I'm not involved in the install process. |
Of course I did, after. |
Yes, I need the PDF attachment's filename (not too concerned for the title) in the json in line with the physically saved filename I manage to do with Zotero. If the attachment filename is incorrect in the json, my Python script's extractor will have no legal file to point to in my Obsidian vault.
Ah, that's a bummer, but still... if I manually export the whole json...it still will not sport my new changed filenames, unless I change the citationKey. So this all this runaround will always be needed?
Well, I'd like for my settings stick... I didn't have problem my auto-export settings not stick in the past. Meh... BTW, all looks okay in settings: |
We are through with that. Initially, for the first tester, I was wary of removing my own official add-on because as I looked around in the plugin settings, I couldn't find an export for the settings and didn't want to remove the extension. So I think I installed the 1st tester on top of the existing one. But as I said, I don't remember now what happened. I'm guessing the 1st tester installed over the official release without a hitch. After this occasion, I always removed the existing extension, quit Zotero, came back to Zotero, installed the next tester and finally for the last time I started debugging before installing the tester, as I recorded in the video. |
OK, no problem. This should have just worked, so that means I'm likely not updating the cache correctly.
No, that's a problem I need to address.
They do stick. Auto-exports are only deleted when removed from the preferences. Which is why I asked.
Then there's something wrong with that too. I'll investigate.
Removing of the extension never removes configuration or data. There is also a facility to export/import preferences, but that should only be needed to get your settings to another computer. New build will drop momentarily |
🤖 this is your friendly neighborhood build bot announcing test build 7.0.5.7608 ("touch parents when child changes") This update may name other issues, but the build just dropped here is for you; it just means problems already fixed in other issues have been folded into the work we are doing here. Install in Zotero by downloading test build 7.0.5.7608, opening the Zotero "Tools" menu, selecting "Add-ons", open the gear menu in the top right, and select "Install Add-on From File...". |
Z3PJ3UWM-euc/7.0.5.7608 |
The one change I've started seeing (don't know since when) is not remembering my preference for 'Keep Updated'. Which reminds me, that when you check it, the Background Export goes unchecked. Maybe that is the source of all our problems? |
Yes. If it didn't always reset, that would be a bug. I don't want people setting up auto-exports by accident.
It should remain checked but disabled. I have no influence on the colorscheme, it is a bit hard to tell, but it remains checked for me. Auto-exports are always background exports. I'll look at the log later when I'm home. |
In my screenshot, I showed the pre-state, before checking 'Keep Updated'. 'Background export' will grey out afterwards. |
Greyed out means the control is disabled (you can't edit it), not that the feature is off (that would show as unchecked, regardless of whether the control is enabled) |
Debug log ID
U7VV7QP3-euc/7.0.5
What happened?
I tried to look for this problem among the Issues and Discussions and and hesitated before writing this up as it should be so basic that I thought it is me that must be doing something wrong.
Case is simple enough:
You realize there is a typo or some other need to rename the attachment and possibly even the parent item.
This can be done two ways:
Wait a few seconds and check the json (if you have set automatic export on changes)... -- No changes in the pdf.
Export the json manually as if doing the export for the very first time for the whole library. -- No changes in the pdf. Rename not reflected.
Current workaround to get the rename updated: manually change BibTex key: this will change the citeKey and adds a property to the Extra YAML key with this change.
Then check the json: the rename update is reflected now.
Is there some way to spare all this, or am I dumb enough to keep doing something wrong?
I tried to create for you some debug lines but not sure what you can make of this. I tried to go up and didn't see the relevant parts.
Then in the meantime I sent the log but not sure if that caught anything, so I kept this for you:
All the best
Z.
The text was updated successfully, but these errors were encountered: