connectPool never returns second time

[GaikwadPratik]

@ronzeidman ,

This is more like a question than an issue. If I invoke await r.connectPool(dbOptions); multiple times(mistakenly), then only the first call returns, the second call or any subsequent calls to the above line never returns and kind of appear to be freezing.

Any idea, why?

[anli-xsigns]

Yes, I spent the whole day finding the issue I had with my code (I had two connectPool too). The problem is in lines

rethinkdb-ts/src/query-builder/r.ts

Lines 51 to 54 in 12fa163

	if ((r as any).pool) {
	((r as any).pool as MasterConnectionPool).removeAllListeners();
	((r as any).pool as MasterConnectionPool).drain();
	}

.
There an existing pool on the same connection will be drained if a new pool is created on the same connection. That can lead to silent errors in my opinion.

At least it is necessary to await the pool finishing the draining in line

rethinkdb-ts/src/query-builder/r.ts

Line 53 in 12fa163

((r as any).pool as MasterConnectionPool).drain();

before (r as any).pool is overwritten while draining in

rethinkdb-ts/src/query-builder/r.ts

Line 59 in 12fa163

(r as any).pool = cpool;

Maybe it is better to throw an error that a pool has to be closed manually before creating a new one instead of silently creating a new pool to avoid clumsy errors.

On the other hand MasterPool can handle an array of serverPools (see

rethinkdb-ts/src/connection/master-pool.ts

Line 66 in 12fa163

this.serverPools = [];

), but that seems to be unused as it is recreated in

rethinkdb-ts/src/query-builder/r.ts

Lines 55 to 59 in 12fa163

	const cpool = new MasterConnectionPool({
	...options,
	servers
	} as any);
	(r as any).pool = cpool;

[atassis]

@GaikwadPratik @anli-xsigns I might resolve this by splitting the logic into separate models, so r won't be a singleton which rules them all. r will only be needed to generate a query, while all connection handling, query running, etc will be handled by different pure functions

[anli-xsigns]

At the moment I'm not using this anymore. Your idea sounds good.

[atassis]

@anli-xsigns you are not using rethinkdb or this exact library?

[anli-xsigns]

I'm not using rethinkdb anymore because work seems to be suspended again.

[atassis]

Can't say thats a bad decision=)