Skip to content

Commit d58d8a1

Browse files
authoredSep 2, 2021
Remove useless imports and redundant type cast (netty#11639)
Motivation: There are some redundant imports and unnecessary type cast Modification: Remove useless imports and unnecessary type cast Result: The code is cleaner than original Signed-off-by: xingrufei <[email protected]>
1 parent 5ebdee8 commit d58d8a1

File tree

7 files changed

+7
-14
lines changed

7 files changed

+7
-14
lines changed
 

‎codec-mqtt/src/main/java/io/netty/handler/codec/mqtt/MqttMessageFactory.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ public static MqttMessage newMessage(MqttFixedHeader mqttFixedHeader, Object var
8282
case AUTH:
8383
//Having MqttReasonCodeAndPropertiesVariableHeader
8484
return new MqttMessage(mqttFixedHeader,
85-
(MqttReasonCodeAndPropertiesVariableHeader) variableHeader);
85+
variableHeader);
8686

8787
default:
8888
throw new IllegalArgumentException("unknown message type: " + mqttFixedHeader.messageType());

‎handler/src/main/java/io/netty/handler/ssl/ReferenceCountedOpenSslContext.java

-1
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,6 @@
4848
import java.security.cert.CertificateRevokedException;
4949
import java.security.cert.X509Certificate;
5050
import java.util.ArrayList;
51-
import java.util.Arrays;
5251
import java.util.Collections;
5352
import java.util.LinkedHashSet;
5453
import java.util.List;

‎handler/src/test/java/io/netty/handler/ssl/OpenSslEngineTest.java

-5
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@
2525
import io.netty.util.CharsetUtil;
2626
import io.netty.util.internal.EmptyArrays;
2727
import io.netty.util.internal.PlatformDependent;
28-
import io.netty.util.internal.ResourcesUtil;
2928
import org.junit.AssumptionViolatedException;
3029
import org.junit.jupiter.api.AfterEach;
3130
import org.junit.jupiter.api.BeforeAll;
@@ -36,30 +35,26 @@
3635
import javax.crypto.Cipher;
3736
import javax.crypto.spec.IvParameterSpec;
3837
import javax.crypto.spec.SecretKeySpec;
39-
import javax.net.ssl.KeyManagerFactory;
4038
import javax.net.ssl.SSLEngine;
4139
import javax.net.ssl.SSLEngineResult;
4240
import javax.net.ssl.SSLEngineResult.HandshakeStatus;
4341
import javax.net.ssl.SSLException;
4442
import javax.net.ssl.SSLHandshakeException;
4543
import javax.net.ssl.SSLParameters;
4644
import javax.net.ssl.X509ExtendedKeyManager;
47-
import java.io.File;
4845
import java.net.Socket;
4946
import java.nio.ByteBuffer;
5047
import java.security.AlgorithmConstraints;
5148
import java.security.AlgorithmParameters;
5249
import java.security.CryptoPrimitive;
5350
import java.security.Key;
54-
import java.security.KeyStore;
5551
import java.security.Principal;
5652
import java.security.PrivateKey;
5753
import java.security.cert.X509Certificate;
5854
import java.util.ArrayList;
5955
import java.util.Arrays;
6056
import java.util.List;
6157
import java.util.Set;
62-
import java.util.concurrent.TimeUnit;
6358

6459
import static io.netty.handler.ssl.OpenSslTestUtils.checkShouldUseKeyManagerFactory;
6560
import static io.netty.handler.ssl.ReferenceCountedOpenSslEngine.MAX_PLAINTEXT_LENGTH;

‎transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollEventLoop.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -391,7 +391,7 @@ protected void run() {
391391
events.increase();
392392
}
393393
} catch (Error e) {
394-
throw (Error) e;
394+
throw e;
395395
} catch (Throwable t) {
396396
handleLoopException(t);
397397
} finally {
@@ -404,7 +404,7 @@ protected void run() {
404404
}
405405
}
406406
} catch (Error e) {
407-
throw (Error) e;
407+
throw e;
408408
} catch (Throwable t) {
409409
handleLoopException(t);
410410
}

‎transport-native-epoll/src/test/java/io/netty/channel/epoll/EpollSocketConnectTest.java

-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717

1818
import io.netty.bootstrap.Bootstrap;
1919
import io.netty.bootstrap.ServerBootstrap;
20-
import io.netty.channel.ChannelOption;
2120
import io.netty.testsuite.transport.TestsuitePermutation;
2221
import io.netty.testsuite.transport.socket.SocketConnectTest;
2322

‎transport-native-kqueue/src/main/java/io/netty/channel/kqueue/KQueueEventLoop.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -298,7 +298,7 @@ protected void run() {
298298
eventList.realloc(false);
299299
}
300300
} catch (Error e) {
301-
throw (Error) e;
301+
throw e;
302302
} catch (Throwable t) {
303303
handleLoopException(t);
304304
} finally {
@@ -311,7 +311,7 @@ protected void run() {
311311
}
312312
}
313313
} catch (Error e) {
314-
throw (Error) e;
314+
throw e;
315315
} catch (Throwable t) {
316316
handleLoopException(t);
317317
}

‎transport/src/main/java/io/netty/channel/nio/NioEventLoop.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -516,7 +516,7 @@ protected void run() {
516516
selector, e);
517517
}
518518
} catch (Error e) {
519-
throw (Error) e;
519+
throw e;
520520
} catch (Throwable t) {
521521
handleLoopException(t);
522522
} finally {
@@ -529,7 +529,7 @@ protected void run() {
529529
}
530530
}
531531
} catch (Error e) {
532-
throw (Error) e;
532+
throw e;
533533
} catch (Throwable t) {
534534
handleLoopException(t);
535535
}

0 commit comments

Comments
 (0)
Please sign in to comment.