Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More improvements #9

Open
xoxys opened this issue Oct 6, 2020 · 3 comments
Open

More improvements #9

xoxys opened this issue Oct 6, 2020 · 3 comments

Comments

@xoxys
Copy link

xoxys commented Oct 6, 2020

Hi, I would like to work on some more improvements:

  • switch to urfave/cli to easily work with multiple config sources; I'm mostly interested in setting options as env vars
  • add CI for
    • test automation
    • publish pre-build binaries with GH release
    • publish a Docker image
  • documentation

I completely understand if you want to leave the base as it is, but I wanted to ask you for your opinion instead of just hacking around in a fork :)

@fd0
Copy link
Member

fd0 commented Oct 7, 2020

Hm, I prefer cobra, which we also use in restic, so we don't have to use two different frameworks. You can extract configuration options via environment variables like here:

https://github.com/restic/restic/blob/0ae02f30303aecac26f8b5cb54f492d240c6cde7/cmd/restic/global.go#L104

CI for test automation is great, I'm not so sure about the docker images (yet at least).

Documentation would be great :)

@xoxys
Copy link
Author

xoxys commented Oct 7, 2020

Thanks for your feedback! Cobra is fine, I'll look into the env var usage. For CI, I guess you would also like to use existing CI Appveyor? Not sure if I could help with that never worked with it :)

@fd0
Copy link
Member

fd0 commented Oct 8, 2020

Nah, I'd love to find the time to migrate restic to GitHub Actions, so I'd prefer that for calens, too. Here are some workflows to get you started (for a different project of mine): https://github.com/happal/taifun/tree/master/.github/workflows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants