Skip to content

fix(render): in node environments react-dom/server is (not ?) always a CJS export #2318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: canary
Choose a base branch
from
Open

fix(render): in node environments react-dom/server is (not ?) always a CJS export #2318

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
54d7ea5
fix(render): in node environments react-dom/server is not always CJS
Tstassin Jun 26, 2025
defff46
also treat edge
gabrielmfern Nov 13, 2025
36785a9
improve code
gabrielmfern Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions packages/render/src/browser/render.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,12 @@ import { readStream } from '../shared/read-stream.browser';

export const render = async (node: React.ReactNode, options?: Options) => {
const suspendedElement = <Suspense>{node}</Suspense>;
const reactDOMServer = await import('react-dom/server.browser').then(
// This is beacuse react-dom/server is CJS
(m) => m.default,
);
const reactDOMServer = await import('react-dom/server').then((m) => {
if ('default' in m) {
return m.default;
}
return m;
});

const html = await new Promise<string>((resolve, reject) => {
reactDOMServer
Expand Down
9 changes: 7 additions & 2 deletions packages/render/src/edge/render.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,13 @@ export const render = async (
) => {
const suspendedElement = <Suspense>{element}</Suspense>;
const reactDOMServer = await importReactDom().then(
// This is because react-dom/server is CJS
(m) => m.default,
(m) => {
if ('default' in m) {
return m.default;
}

return m;
},
);

const html = await new Promise<string>((resolve, reject) => {
Expand Down
10 changes: 6 additions & 4 deletions packages/render/src/node/render.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,12 @@ import { readStream } from './read-stream';

export const render = async (node: React.ReactNode, options?: Options) => {
const suspendedElement = <Suspense>{node}</Suspense>;
const reactDOMServer = await import('react-dom/server').then(
// This is beacuse react-dom/server is CJS
(m) => m.default,
);
const reactDOMServer = await import('react-dom/server').then((m) => {
if ('default' in m) {
return m.default;
}
return m;
});

let html!: string;
if (
Expand Down
Loading