Remove unwanted float primitives

Author: cometkim

Diff for: jscomp/core/lam_dispatch_primitive.ml

@@ -52,13 +52,6 @@ let translate loc (prim_name : string) (args : J.expression list) : J.expression
   (******************************************************************************)
   (************************* customized primitives ******************************)
   (******************************************************************************)
-  | "?int_of_float" -> (
-      match args with [ e ] -> E.to_int32 e | _ -> assert false)
-  | "?int_float_of_bits" | "?int_bits_of_float" | "?modf_float" | "?ldexp_float"
-  | "?frexp_float" | "?copysign_float" | "?expm1_float" | "?hypot_float" ->
-      call Js_runtime_modules.float
-  | "?fmod_float" (* float module like js number module *) -> (
-      match args with [ e0; e1 ] -> E.float_mod e0 e1 | _ -> assert false)
   (* Note we captured [exception/extension] creation in the early pass, this primitive is
       like normal one to set the identifier *)
   | "?exn_slot_name" | "?is_extension" -> call Js_runtime_modules.exceptions

Diff for: jscomp/runtime/caml_hash.res

@@ -22,7 +22,7 @@
  * along with this program; if not, write to the Free Software
  * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */
 
-external int_of_float: float => int = "?int_of_float"
+external int_of_float: float => int = "%intoffloat"
 
 type rec cell<'a> = {
   content: 'a,

Diff for: jscomp/runtime/primitive_float.res

@@ -26,118 +26,3 @@ let max = (x: float, y: float): float =>
   } else {
     y
   }
-
-// TODO: delete below
-
-/* borrowed from others/js_math.ml */
-@val external _LOG2E: float = "Math.LOG2E"
-@val external _LOG10E: float = "Math.LOG10E"
-@val external abs_float: float => float = "Math.abs"
-@val external floor: float => float = "Math.floor"
-@val @scope("Math") external exp: float => float = "exp"
-@val external log: float => float = "Math.log"
-@val @scope("Math") external sqrt: float => float = "sqrt"
-@val external pow_float: (~base: float, ~exp: float) => float = "Math.pow"
-external int_of_float: float => int = "%intoffloat"
-external float_of_int: int => float = "%floatofint"
-
-let int_float_of_bits: int => float = %raw(`function(x){
-    return new Float32Array(new Int32Array([x]).buffer)[0] 
-    }`)
-let int_bits_of_float: float => int = %raw(`function(x){
-  return new Int32Array(new Float32Array([x]).buffer)[0] 
-}`)
-
-let modf_float = (x: float): (float, float) =>
-  if Primitive_float_extern.isFinite(x) {
-    let neg = 1. /. x < 0.
-    let x = abs_float(x)
-    let i = floor(x)
-    let f = x -. i
-    if neg {
-      (-.f, -.i)
-    } else {
-      (f, i)
-    }
-  } else if Primitive_float_extern.isNaN(x) {
-    (Primitive_float_extern._NaN, Primitive_float_extern._NaN)
-  } else {
-    (1. /. x, x)
-  }
-
-let ldexp_float = (x: float, exp: int): float => {
-  let (x', exp') = (ref(x), ref(float_of_int(exp)))
-  if exp'.contents > 1023. {
-    exp'.contents = exp'.contents -. 1023.
-    x'.contents = x'.contents *. pow_float(~base=2., ~exp=1023.)
-    if exp'.contents > 1023. {
-      /* in case x is subnormal */
-      exp'.contents = exp'.contents -. 1023.
-      x'.contents = x'.contents *. pow_float(~base=2., ~exp=1023.)
-    }
-  } else if exp'.contents < -1023. {
-    exp'.contents = exp'.contents +. 1023.
-    x'.contents = x'.contents *. pow_float(~base=2., ~exp=-1023.)
-  }
-  x'.contents *. pow_float(~base=2., ~exp=exp'.contents)
-}
-
-let frexp_float = (x: float): (float, int) =>
-  if x == 0. || !Primitive_float_extern.isFinite(x) {
-    (x, 0)
-  } else {
-    let neg = x < 0.
-    let x' = ref(abs_float(x))
-    let exp = ref(floor(_LOG2E *. log(x'.contents)) +. 1.)
-
-    x'.contents = x'.contents *. pow_float(~base=2., ~exp=-.exp.contents)
-    if x'.contents < 0.5 {
-      x'.contents = x'.contents *. 2.
-      exp.contents = exp.contents -. 1.
-    }
-    if neg {
-      x'.contents = -.x'.contents
-    }
-    (x'.contents, int_of_float(exp.contents))
-  }
-
-let copysign_float = (x: float, y: float): float => {
-  let x = abs_float(x)
-  let y = if y == 0. {
-    1. /. y
-  } else {
-    y
-  }
-  if y < 0. {
-    -.x
-  } else {
-    x
-  }
-}
-
-/* http://www.johndcook.com/blog/cpp_expm1/ */
-let expm1_float: float => float = x =>
-  switch x {
-  | x =>
-    let y = exp(x)
-    let z = y -. 1.
-    if abs_float(x) > 1. {
-      z
-    } else if z == 0. {
-      x
-    } else {
-      x *. z /. log(y)
-    }
-  }
-
-let hypot_float = (x: float, y: float): float => {
-  let (x0, y0) = (abs_float(x), abs_float(y))
-  let a = max(x0, y0)
-  let b =
-    min(x0, y0) /. if a != 0. {
-      a
-    } else {
-      1.
-    }
-  a *. sqrt(1. +. b *. b)
-}

Diff for: jscomp/runtime/primitive_float_extern.res

@@ -37,10 +37,9 @@ o runtime/curry.cmi runtime/curry.cmj : cc runtime/curry.res | runtime/bs_stdlib
 o runtime/primitive_array.cmi runtime/primitive_array.cmj : cc runtime/primitive_array.res | runtime/bs_stdlib_mini.cmi runtime/js.cmi runtime/js.cmj
 o runtime/primitive_bigint.cmi runtime/primitive_bigint.cmj : cc runtime/primitive_bigint.res | runtime/bs_stdlib_mini.cmi runtime/js.cmi runtime/js.cmj
 o runtime/primitive_bool.cmi runtime/primitive_bool.cmj : cc runtime/primitive_bool.res | runtime/bs_stdlib_mini.cmi runtime/js.cmi runtime/js.cmj
-o runtime/primitive_float.cmi runtime/primitive_float.cmj : cc runtime/primitive_float.res | runtime/bs_stdlib_mini.cmi runtime/js.cmi runtime/js.cmj runtime/primitive_float_extern.cmj
-o runtime/primitive_float_extern.cmi runtime/primitive_float_extern.cmj : cc runtime/primitive_float_extern.res | runtime/bs_stdlib_mini.cmi runtime/js.cmi runtime/js.cmj
+o runtime/primitive_float.cmi runtime/primitive_float.cmj : cc runtime/primitive_float.res | runtime/bs_stdlib_mini.cmi runtime/js.cmi runtime/js.cmj
 o runtime/primitive_int.cmi runtime/primitive_int.cmj : cc runtime/primitive_int.res | runtime/bs_stdlib_mini.cmi runtime/js.cmi runtime/js.cmj
 o runtime/primitive_promise.cmi runtime/primitive_promise.cmj : cc runtime/primitive_promise.res | runtime/bs_stdlib_mini.cmi runtime/js.cmi runtime/js.cmj
 o runtime/primitive_string.cmi runtime/primitive_string.cmj : cc runtime/primitive_string.res | runtime/bs_stdlib_mini.cmi runtime/js.cmi runtime/js.cmj runtime/primitive_string_extern.cmj
 o runtime/primitive_string_extern.cmi runtime/primitive_string_extern.cmj : cc runtime/primitive_string_extern.res | runtime/bs_stdlib_mini.cmi runtime/js.cmi runtime/js.cmj
-o runtime : phony runtime/bs_stdlib_mini.cmi runtime/js.cmj runtime/js.cmi runtime/caml_exceptions.cmi runtime/caml_exceptions.cmj runtime/caml_hash.cmi runtime/caml_hash.cmj runtime/caml_hash_primitive.cmi runtime/caml_hash_primitive.cmj runtime/caml_option.cmi runtime/caml_option.cmj runtime/caml_splice_call.cmi runtime/caml_splice_call.cmj runtime/lazy.cmi runtime/lazy.cmj runtime/primitive_lazy.cmi runtime/primitive_lazy.cmj runtime/primitive_module.cmi runtime/primitive_module.cmj runtime/primitive_object.cmi runtime/primitive_object.cmj runtime/caml_js_exceptions.cmi runtime/caml_js_exceptions.cmj runtime/caml_undefined_extern.cmi runtime/caml_undefined_extern.cmj runtime/curry.cmi runtime/curry.cmj runtime/primitive_array.cmi runtime/primitive_array.cmj runtime/primitive_bigint.cmi runtime/primitive_bigint.cmj runtime/primitive_bool.cmi runtime/primitive_bool.cmj runtime/primitive_float.cmi runtime/primitive_float.cmj runtime/primitive_float_extern.cmi runtime/primitive_float_extern.cmj runtime/primitive_int.cmi runtime/primitive_int.cmj runtime/primitive_promise.cmi runtime/primitive_promise.cmj runtime/primitive_string.cmi runtime/primitive_string.cmj runtime/primitive_string_extern.cmi runtime/primitive_string_extern.cmj
+o runtime : phony runtime/bs_stdlib_mini.cmi runtime/js.cmj runtime/js.cmi runtime/caml_exceptions.cmi runtime/caml_exceptions.cmj runtime/caml_hash.cmi runtime/caml_hash.cmj runtime/caml_hash_primitive.cmi runtime/caml_hash_primitive.cmj runtime/caml_option.cmi runtime/caml_option.cmj runtime/caml_splice_call.cmi runtime/caml_splice_call.cmj runtime/lazy.cmi runtime/lazy.cmj runtime/primitive_lazy.cmi runtime/primitive_lazy.cmj runtime/primitive_module.cmi runtime/primitive_module.cmj runtime/primitive_object.cmi runtime/primitive_object.cmj runtime/caml_js_exceptions.cmi runtime/caml_js_exceptions.cmj runtime/caml_undefined_extern.cmi runtime/caml_undefined_extern.cmj runtime/curry.cmi runtime/curry.cmj runtime/primitive_array.cmi runtime/primitive_array.cmj runtime/primitive_bigint.cmi runtime/primitive_bigint.cmj runtime/primitive_bool.cmi runtime/primitive_bool.cmj runtime/primitive_float.cmi runtime/primitive_float.cmj runtime/primitive_int.cmi runtime/primitive_int.cmj runtime/primitive_promise.cmi runtime/primitive_promise.cmj runtime/primitive_string.cmi runtime/primitive_string.cmj runtime/primitive_string_extern.cmi runtime/primitive_string_extern.cmj

Diff for: jscomp/runtime/release.ninja

@@ -12,9 +12,6 @@ module StandardNotation = {
   }
   let hh = M.sum(1.0, 2.0)
 
-  external mod_float: (float, float) => float = "?fmod_float"
-  let mf = mod_float(3., 4.)
-
   @get_index external get: (array<string>, int) => option<'a> = ""
   let tg = arr => arr->get(0)