tests: clean up some tests to avoid build error with stale output (#7355)

Author: aspeddro

scripts/test.js

@@ -143,16 +143,14 @@ if (runtimeDocstrings) {
     console.log("Running runtime docstrings tests");
 
     const generated_mocha_test_res = path.join(
-      "tests",
-      "docstring_tests",
+      docstringTestDir,
       "generated_mocha_test.res",
     );
 
-    // Remove `generated_mocha_test.res` if file exists
-    if (fs.existsSync(generated_mocha_test_res)) {
-      console.log(`Removing ${generated_mocha_test_res}`);
-      fs.unlinkSync(generated_mocha_test_res);
-    }
+    await execClean([], {
+      cwd: docstringTestDir,
+      stdio: "inherit"
+    })
 
     await execBuild([], {
       cwd: docstringTestDir,
@@ -180,7 +178,7 @@ if (runtimeDocstrings) {
 
     console.log("Run mocha test");
     await mocha(
-      [path.join("tests", "docstring_tests", "generated_mocha_test.res.js")],
+      [path.join(docstringTestDir, "generated_mocha_test.res.js")],
       {
         cwd: projectDir,
         stdio: "inherit",

tests/build_tests/jsx_settings_inheritance/input.js

@@ -2,6 +2,7 @@
 
 import { setup } from "#dev/process";
 
-const { execBuild } = setup(import.meta.dirname);
+const { execBuild, execClean } = setup(import.meta.dirname);
 
+await execClean()
 await execBuild();

tests/build_tests/transitive_pinned_dependency1/input.js

@@ -4,7 +4,9 @@ import * as assert from "node:assert";
 import { existsSync } from "node:fs";
 import { setup } from "#dev/process";
 
-const { execBuild } = setup("./a");
+const { execBuild, execClean } = setup("./a");
+
+await execClean()
 
 const output = await execBuild();
 console.log(output);

tests/build_tests/transitive_pinned_dependency2/input.js

@@ -4,8 +4,8 @@ import * as assert from "node:assert";
 import { existsSync } from "node:fs";
 import { setup } from "#dev/process";
 
-const { execBuild } = setup("./a");
-
+const { execBuild, execClean } = setup("./a");
+await execClean()
 const output = await execBuild();
 console.log(output);