Add link from legacy Js modules to their current Core equivalents.#879
Closed
gaspard wants to merge 1 commit intorescript-lang:masterfrom
Closed
Add link from legacy Js modules to their current Core equivalents.#879gaspard wants to merge 1 commit intorescript-lang:masterfrom
gaspard wants to merge 1 commit intorescript-lang:masterfrom
Conversation
Having a clear warning that Core supersedes Js helps remove some confusion for newcomers. It also avoids people trying to understand code samples that use legacy features such as |>.
|
@gaspard is attempting to deploy a commit to the ReScript Association Team on Vercel. A member of the Team first needs to authorize it. |
Collaborator
Member
|
@aspeddro would we not need to add the deprecation messages to the compiler sources themselves? |
Collaborator
|
If when In short, it depends on how the transition from |
Collaborator
|
The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having a clear warning that Core supersedes Js helps remove some confusion for newcomers. It also avoids people trying to understand code samples that use legacy features such as |>.