Skip to content

Commit 7a4ce15

Browse files
committed
Only reset warning flags, not other config, when clicking warning flag reset button
1 parent 92bb2ea commit 7a4ce15

File tree

1 file changed

+9
-28
lines changed

1 file changed

+9
-28
lines changed

src/Playground.res

Lines changed: 9 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -793,20 +793,12 @@ module WarningFlagsWidget = {
793793
| []
794794
| [{enabled: false, flag: "a"}] => React.null
795795
| _ =>
796-
let onMouseDown = evt => {
797-
ReactEvent.Mouse.preventDefault(evt)
796+
let onClick = _evt => {
798797
onUpdate([{WarningFlagDescription.Parser.enabled: false, flag: "a"}])
799798
}
800799

801-
// For iOS12 compat
802-
let onClick = _ => ()
803-
let onFocus = evt => {
804-
ReactEvent.Focus.preventDefault(evt)
805-
ReactEvent.Focus.stopPropagation(evt)
806-
}
807-
808800
<button
809-
onMouseDown
801+
title="Clear all flags"
810802
onClick
811803
onFocus
812804
tabIndex=0
@@ -891,23 +883,11 @@ module Settings = {
891883

892884
let warnFlagTokens = WarningFlagDescription.Parser.parse(warn_flags)->Result.getOr([])
893885

894-
let onResetClick = evt => {
895-
ReactEvent.Mouse.preventDefault(evt)
896-
897-
let open_modules = switch readyState.selected.apiVersion {
898-
| V1 | V2 | V3 | UnknownVersion(_) => None
899-
| V4 | V5 =>
900-
readyState.selected.libraries->Array.some(el => el === "@rescript/core")
901-
? Some(["RescriptCore"])
902-
: None
903-
}
904-
905-
let defaultConfig = {
906-
Api.Config.module_system: "nodejs",
907-
warn_flags: "+a-4-9-20-40-41-42-50-61-102-109",
908-
?open_modules,
909-
}
910-
setConfig(defaultConfig)
886+
let onWarningFlagsResetClick = _evt => {
887+
setConfig({
888+
...config,
889+
warn_flags: "+a-4-9-20-40-41-50-61-102-109",
890+
})
911891
}
912892

913893
let onCompilerSelect = id => dispatch(SwitchToCompiler(id))
@@ -1028,7 +1008,8 @@ module Settings = {
10281008
<div className="mt-8">
10291009
<div className=titleClass>
10301010
{React.string("Warning Flags")}
1031-
<button onMouseDown=onResetClick className={"ml-6 text-12 " ++ Text.Link.standalone}>
1011+
<button
1012+
onClick=onWarningFlagsResetClick className={"ml-6 text-12 " ++ Text.Link.standalone}>
10321013
{React.string("[reset]")}
10331014
</button>
10341015
</div>

0 commit comments

Comments
 (0)