Skip to content

Commit 4efd459

Browse files
committed
Fix insufficiently sized array in write_gamestate()
1 parent 082540a commit 4efd459

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

src/server/user.c

+4-2
Original file line numberDiff line numberDiff line change
@@ -96,11 +96,13 @@ static void SV_CreateBaselines(void)
9696
}
9797
}
9898

99+
// Data needed for write_gamestate. Too large for stack, so store statically.
100+
static q2proto_svc_configstring_t configstrings[MAX_CONFIGSTRINGS];
101+
static q2proto_svc_spawnbaseline_t spawnbaselines[MAX_EDICTS];
102+
99103
static void write_gamestate(void)
100104
{
101105
msgEsFlags_t baseline_flags = sv_client->q2proto_ctx.features.has_beam_old_origin_fix ? MSG_ES_BEAMORIGIN : 0;
102-
q2proto_svc_configstring_t configstrings[MAX_CONFIGSTRINGS];
103-
q2proto_svc_spawnbaseline_t spawnbaselines[MAX_PACKET_ENTITIES];
104106
q2proto_gamestate_t gamestate = {.num_configstrings = 0, .configstrings = configstrings, .num_spawnbaselines = 0, .spawnbaselines = spawnbaselines};
105107
memset(spawnbaselines, 0, sizeof(spawnbaselines));
106108

0 commit comments

Comments
 (0)