Merge pull request #1138 from replicatedhq/laverya/upgrade-node-10

use node 12, not node 8, in CI

Author: laverya

.circleci/config.yml

@@ -10,7 +10,7 @@ jobs:
 
   build_web_init:
     docker:
-      - image: circleci/node:8
+      - image: circleci/node:12
     working_directory: ~/ship
     steps:
       - checkout
@@ -45,7 +45,7 @@ jobs:
             - ship/web/init/package.json
   build_web_app:
     docker:
-      - image: circleci/node:8
+      - image: circleci/node:12
     working_directory: ~/ship
     steps:
       - checkout
@@ -106,7 +106,7 @@ jobs:
             - ship/bin
   e2e_setup:
     docker:
-      - image: cypress/browsers:node8.9.3-chrome73
+      - image: cypress/browsers:node12.18.3-chrome87-ff82
     working_directory: ~/ship
     steps:
       - checkout
@@ -130,7 +130,7 @@ jobs:
           key: ship-e2e-setup-cy-3.2.0
   e2e_init:
     docker:
-      - image: cypress/browsers:node8.9.3-chrome73
+      - image: cypress/browsers:node12.18.3-chrome87-ff82
     working_directory: ~/ship
     steps:
       - checkout
@@ -167,6 +167,11 @@ jobs:
 
             retry make cypress_base
 
+      - store_artifacts:
+          name: Uploading cypress screenshots to help with debugging
+          path: /root/ship/web/app/cypress/screenshots
+          when: on_fail
+
   test:
     docker:
       - image: circleci/golang:1.13
@@ -503,7 +508,7 @@ jobs:
 
   ui:
     docker:
-      - image: circleci/node:8
+      - image: circleci/node:12
     working_directory: ~/ship
     steps:
       - checkout
@@ -527,7 +532,7 @@ jobs:
 
   deploy_ship_init:
     docker:
-      - image: circleci/node:8
+      - image: circleci/node:12
     working_directory: ~/ship
     steps:
       - run: |