Skip to content

Unified timeout for sending a message #69

Description

@rahulghangas

Currently the Send method in the peer module, and consequently, the Send method in transport uses a user supplied context for timeout. This causes multiple timing issues across gossipping and syncing if not configured with proper times. Also, using two different timeouts can get confusing. There are two potential solution that come to mind

  1. remove the context parameter and have a single timeout for Send that gets configured while creating the transport layer.
  2. Since some messages might be quite big and might not finish in the timeout specified in the transport layer, create two methods for sending a message
    • where the timeout field from the transport layer is used
    • where the user supplies the context with a custom timeout

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions