fix(manager/uv): handle unnamed index #34387
Open
+6
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkniewallner
force-pushed
the
fix/handle-uv-unnamed-index
branch
from
ccd723b to
e2c4617
Compare
mkniewallner
commented
Feb 22, 2025
| @@ -339,6 +339,11 @@ async function getUvIndexCredentials( | |||
| const entries = []; | |||
|
|
|||
| for (const { name, url } of uv_indexes) { | |||
| // istanbul ignore if | |||
There was a problem hiding this comment.
Already covered by type-checking.
viceice
requested changes
Feb 24, 2025
| @@ -339,6 +339,11 @@ async function getUvIndexCredentials( | |||
| const entries = []; | |||
|
|
|||
| for (const { name, url } of uv_indexes) { | |||
| // istanbul ignore if | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Make
nameoptional for uv indexes, per https://docs.astral.sh/uv/configuration/indexes/#defining-an-index.Context
nameis optional undertool.uv.index, but Renovate considers it required #34428Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: