Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip -d flag for "go get" if go 1.18 or later is run #34097

Open
rarkins opened this issue Feb 7, 2025 · 0 comments
Open

Skip -d flag for "go get" if go 1.18 or later is run #34097

rarkins opened this issue Feb 7, 2025 · 0 comments
Labels
manager:gomod Go Modules priority-4-low Low priority, unlikely to be done unless it becomes important to more people type:feature Feature (new functionality)

Comments

@rarkins
Copy link
Collaborator

rarkins commented Feb 7, 2025

Describe the proposed change(s).

As originally proposed in #32506 but not completed, the -d flag is not necessary for go 1.18 or later.

It's important that Renovate to keep the -d flag if an older version of go is run, although that is rare.

The go toolchain directive was introduced in Go 1.21 so it's not possible for it to be a scenario where <1.18 is used.

The only way which Go could be pinned to a lower version is if the user configures constraints.go in Renovate config, so this edge case should be considered.

@rarkins rarkins added manager:gomod Go Modules priority-4-low Low priority, unlikely to be done unless it becomes important to more people type:feature Feature (new functionality) labels Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
manager:gomod Go Modules priority-4-low Low priority, unlikely to be done unless it becomes important to more people type:feature Feature (new functionality)
Projects
None yet
Development

No branches or pull requests

1 participant