Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incomplete bitbucket-server user with empty email string results in invalid gitAuthor #31175

Open
rarkins opened this issue Sep 3, 2024 Discussed in #31174 · 0 comments
Open
Labels
platform:bitbucket-server Bitbucket Data Center and Server platform priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:bug Bug fix of existing functionality

Comments

@rarkins
Copy link
Collaborator

rarkins commented Sep 3, 2024

Discussed in #31174

Originally posted by Kiskae September 3, 2024

What would you like help with?

I think I found a bug

How are you running Renovate?

Self-hosted

If you're self-hosting Renovate, tell us which platform (GitHub, GitLab, etc) and which version of Renovate.

bitbucket-server, renovate 38.52.2

Please tell us more about your question or problem

Unable to provide a reproduction since it involves just the platform integration.

Root cause appears to be this change: #29525

I've traced it to the fact that the bitbucket server account linked to the renovate token does not have an email address configured, this causes the change above to set the gitAuthor to a value without an email and triggers the validation error later on.

Essentially the value emailAddress in the following line can be an empty string:
https://github.com/amezin/renovate/blob/745978f11ffbc2585be20f005fdbe854b19b466c/lib/modules/platform/bitbucket-server/index.ts#L151

Logs (if relevant)

Logs

[2024-09-03T07:17:48.267Z]          "validationSource": "None",
[2024-09-03T07:17:48.267Z]          "validationError": "Invalid gitAuthor",
[2024-09-03T07:17:48.267Z]          "validationMessage": "`gitAuthor` is not parsed as valid RFC5322 format: `******* <>`",
[2024-09-03T07:17:48.267Z]          "message": "config-validation",

@rarkins rarkins added type:bug Bug fix of existing functionality priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others platform:bitbucket-server Bitbucket Data Center and Server platform labels Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform:bitbucket-server Bitbucket Data Center and Server platform priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:bug Bug fix of existing functionality
Projects
None yet
Development

No branches or pull requests

1 participant