Skip to content

Commit cda42f8

Browse files
committed
Merge branch 'release/v0.1.3'
2 parents c743fb2 + c23939c commit cda42f8

File tree

8 files changed

+2639
-2501
lines changed

8 files changed

+2639
-2501
lines changed

.travis.yml

Lines changed: 5 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -4,23 +4,16 @@ os:
44
- linux
55
- osx
66
node_js:
7-
- 8
8-
- 7
97
- 6
10-
- node
8+
- 8
9+
- "10.15.0"
1110
before_install:
12-
- curl -o- -L https://yarnpkg.com/install.sh | bash -s -- --version 1.10.1
13-
- export PATH=$HOME/.yarn/bin:$PATH
14-
- yarn global add greenkeeper-lockfile@1
15-
install:
16-
- yarn install --ignore-engines
17-
cache:
18-
yarn: true
11+
- npm install -g greenkeeper-lockfile
1912
before_script: greenkeeper-lockfile-update
2013
after_script: greenkeeper-lockfile-upload
2114
after_success:
22-
- yarn cover
23-
- ./node_modules/.bin/codecov
15+
- npm run cover
16+
- npx codecov
2417
env:
2518
global:
2619
secure: eGptEeBpj9rsGNLF6cqvXsclE6QBCWABReVPq5ueQ0LqeE8/bXKKDoIWSkFL105Zk0grqUiMRESfIr7CWFyFlT75MhE1/QfKsGtNtJoZ4FQMb/a85VjQLBWEX9Nr34+R+FMv3a2HY49SuFhFcyndSbPZ4vc3lV48+gV/QzbKT2vNSjgH2wQrMlqgkg3Sg8sghdaVsKWsd3TxLX+PvfZD23M+bYMf1CGO0bub4kUuAZ+EfTi+nVFE5XQVZP5Ln8Ypwy8FyftxBIiYu6DkuXoGoBZxr9Ov70ANCIJeDsAhRioDSJ/33VtgSuBLjEoBgZsrdSet5q95/t4iPdzqfQlqTJvJ1uhwdWP/OdiH6Eip+elLGb4m1xaLMjCyCGY1FL5RnafCYRFsyIZWE2H1qQnOrd4gnfZx03Yrmg6ZnodyqvEp8sVvLxl5aWiiv9QMlTK1s6z23I9g1zx3kYcY0vBvdgEFCG/1vmD0dqK3A3/wr58EVeR01nj+pbqeJtnXk1bu9eTV2p9YpVsHpjM33sqwXtqoPegCGGuAsLyWoszjfK6ZhEMLS7T8Wlf8ECACd60u/5T+d7rOqhfCaCdkXu4kZczpZ9EeFBTpuHPRFDEvTNka35HXoFoY8c0TXY0zE3wSJL7xubKVPO/lFjsPREuQXxTOcSvnNxLQrL4+wjjQW9w=

README.md

Lines changed: 6 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -9,19 +9,12 @@ Command line application allowing you to download all issues in the CSV format f
99

1010
## Requirements
1111

12-
- [Node.js](https://nodejs.org) `v8.10.0 LTS` (tested on versions `6`, `7`, `8` and `latest`)
13-
- [Yarn](https://yarnpkg.com) `1.10.1`
12+
- [Node.js](https://nodejs.org) `v10.15.0 LTS` (tested on versions `6`, `7`, `8` and `latest`)
1413

1514
## Installation
1615

17-
Via `npm`
18-
1916
npm install -g git-issues-downloader
2017

21-
Via `yarn`
22-
23-
yarn global add git-issues-downloader
24-
2518
## Usage
2619

2720
git-issues-downloader <repository URL>
@@ -42,24 +35,24 @@ Example with username and password
4235

4336
git clone [email protected]:remoteorigin/git-issues-downloader.git
4437
cd git-issues-downloader
45-
yarn install
38+
npm install
4639

4740
### Run Project
4841

49-
yarn start
42+
npm start
5043

5144
### Tests
5245

5346
All tests are are written in [Mocha](https://mochajs.org/) and stored in the `test` folder.
5447

55-
yarn test
48+
npm run test
5649

5750
### Linting
5851

5952
Using [Standard](https://github.com/feross/standard) JavaScript linter & automatic code fixer.
6053

61-
yarn lint
54+
npm run lint
6255

6356
Automatically fix linting issues
6457

65-
yarn lint:fix
58+
npm run lint:fix

app.js

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -26,13 +26,12 @@ const outputFileName = argv.filename
2626
// callback function for getting input from prompt
2727

2828
const getAuth = function (auth, silent, callback) {
29-
read({prompt: `${auth}: `, silent: silent}, function (er, password) {
29+
read({ prompt: `${auth}: `, silent: silent }, function (er, password) {
3030
callback(password)
3131
})
3232
}
3333

3434
// callback function for getting requested options
35-
3635
const getRequestedOptions = exports.getRequestedOptions = function (username, password, url, callback) {
3736
const requestOptions = {
3837
headers: {
@@ -86,14 +85,13 @@ const getRequestedOptions = exports.getRequestedOptions = function (username, pa
8685
const main = exports.main = function (data, requestedOptions) {
8786
logExceptOnTest('Requesting API...')
8887
requestBody(requestedOptions, (error, response, body) => {
89-
linkObject = responseToObject(response.headers)
88+
const linkObject = responseToObject(response.headers)
89+
9090
if (error) {
9191
chalk.red('There has been an error requesting data from GitHub')
9292
console.error(error)
9393
}
9494

95-
const linkObject = responseToObject(response.headers)
96-
9795
// take body, parse it and add it to data
9896

9997
data = _.concat(data, body)
@@ -211,4 +209,4 @@ function logExceptOnTest (string) {
211209

212210
const argvRepository = argv._[argv._.length - 1]
213211

214-
this.execute(argvRepository)
212+
execute(argvRepository)

0 commit comments

Comments
 (0)