Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rehype-minify-whitspace: TypeError: Cannot read properties of undefined (reading 'hidden') #49

Closed
4 tasks done
tripodsan opened this issue Sep 4, 2023 · 2 comments
Closed
4 tasks done

rehype-minify-whitspace: TypeError: Cannot read properties of undefined (reading 'hidden') #49

tripodsan opened this issue Sep 4, 2023 · 2 comments
Labels
🙅 no/wontfix This is not (enough of) an issue for this project 👎 phase/no Post cannot or will not be acted on

Comments

@tripodsan
Copy link

Initial checklist

Affected packages and versions

[email protected]

Link to runnable example

No response

Steps to reproduce

passing a node w/o properties causes an error in:

https://github.com/rehypejs/rehype-minify/blob/main/packages/rehype-minify-whitespace/lib/index.js#L291

Expected behavior

node w/o properties should be ignored.

Actual behavior

node w/o properties causes an error.

Runtime

Node v16

Package manager

npm 8

OS

macOS

Build and bundle tools

No response
@github-actions github-actions bot added 👋 phase/new Post is being triaged automatically 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Sep 4, 2023
@wooorm
Copy link
Member

wooorm commented Sep 4, 2023 •
edited
Loading

Hi. This is expected. This is one of the major changes. All elements must have properties (previously they should have properties). Make sure when you have your own code that generates elements, that a properties object exists!

@wooorm wooorm closed this as not planned Won't fix, can't repro, duplicate, stale Sep 4, 2023
@wooorm wooorm added the 🙅 no/wontfix This is not (enough of) an issue for this project label Sep 4, 2023
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot added 👎 phase/no Post cannot or will not be acted on and removed 🤞 phase/open Post is being triaged manually labels Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🙅 no/wontfix This is not (enough of) an issue for this project 👎 phase/no Post cannot or will not be acted on
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tripodsan @wooorm