Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(devtools-server): bump express to ^4.21.0 #6354

Merged

Conversation

arndom
Copy link
Contributor

@arndom arndom commented Sep 18, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

Bugs / Features

What is the current behavior?

What is the new behavior?

fixes #6321

Notes for reviewers

@arndom arndom requested a review from a team as a code owner September 18, 2024 22:30
Copy link

changeset-bot bot commented Sep 18, 2024

🦋 Changeset detected

Latest commit: 9374fd8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@refinedev/devtools-server Patch
@refinedev/cli Patch
@refinedev/devtools Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@BatuhanW BatuhanW changed the base branch from master to releases/october September 19, 2024 06:50
@BatuhanW BatuhanW added this to the October Release milestone Sep 19, 2024
Copy link
Member

@BatuhanW BatuhanW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @arndom can you do pnpm install, so pnpm-lock.yaml will be updated?

@arndom
Copy link
Contributor Author

arndom commented Sep 19, 2024

@BatuhanW For some reason pnpm install isn't updating the pnpm-lock.yaml.

it isn't even creating the node_modules after I deleted it, assuming that was the problem.

Copy link
Member

@aliemir aliemir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the update @arndom, in addition to @BatuhanW's comment; can you please update the express version in packages/devtools-server (requires a changeset too) and examples/mern-dashboard-server to keep it consistent in the workspace? 🙏

About pnpm install, are you running this command at the root of the repo? Were you able to run pnpm install successfully after you cloned it? 🤔

@arndom
Copy link
Contributor Author

arndom commented Sep 20, 2024

@aliemir I'll update the express version of the two 👍

Now that you mention it, I had tried pnpm install at the root after the clone but it ran without generating the node_modules so I used npm install so that I could then run the changeset script.

  • I've tried --force, --lockfile-only options to no avail,
  • reinstalled pnpm, same issue; no node-modules or lockfile generation in the refine project
  • created a blank project to see if pnpm was the issue but it was working normally there,

So I'm stuck at the moment.

Here are some details in case you need them:

  • pnpm: v9.10.0
  • node: v20.9.0
  • os: win11
  • editor: vscode

my git bash

$ pnpm install
Scope: all 238 workspace projects
. pnpm:devPreinstall$ node scripts/fix-pnpm-symlinks.js
└─ Done in 171ms
examples/blog-ecommerce                  |  WARN  deprecated [email protected]
examples/i18n-react                      |  WARN  deprecated [email protected]
examples/with-web3                       |  WARN  deprecated [email protected]
packages/live-previews                   |  WARN  deprecated @refinedev/[email protected]
 WARN  deprecated @lerna/[email protected]: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.
packages/cli                             |  WARN  deprecated [email protected]
Progress: resolved 4480, reused 0, downloaded 0, added 0

@arndom
Copy link
Contributor Author

arndom commented Sep 21, 2024

So I could only 'successfully' run pnpm install in the master branch to create the node modules folder.

But if you delete the pnpm-lock and node_modules there is no generation of either; just as it was in my fix branch it runs without any output (see bash in previous comment)

Copy link
Member

@aliemir aliemir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @arndom, I've just pushed couple of commits including the changes in pnpm-lock.yaml. I'll investigate the issue, it might be happening due to version changes in the packages and syncpack might been blocking the install 🤔

I've checked and saw that express is not actually used in @refinedev/cli anymore. I've removed the dependency and kept the other version updates as is.

Thank you for your contribution 🙏

@aliemir aliemir changed the title fix(cli): bump express to ^4.21.0 fix(devtools-server): bump express to ^4.21.0 Sep 23, 2024
@aliemir aliemir merged commit da9da4e into refinedev:releases/october Sep 23, 2024
12 checks passed
This was referenced Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Moderate vulnerability in @refinedev/[email protected]
3 participants