-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(devtools-server): bump express
to ^4.21.0
#6354
fix(devtools-server): bump express
to ^4.21.0
#6354
Conversation
🦋 Changeset detectedLatest commit: 9374fd8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @arndom can you do pnpm install, so pnpm-lock.yaml
will be updated?
@BatuhanW For some reason it isn't even creating the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the update @arndom, in addition to @BatuhanW's comment; can you please update the express
version in packages/devtools-server
(requires a changeset too) and examples/mern-dashboard-server
to keep it consistent in the workspace? 🙏
About pnpm install
, are you running this command at the root of the repo? Were you able to run pnpm install
successfully after you cloned it? 🤔
@aliemir I'll update the express version of the two 👍 Now that you mention it, I had tried
So I'm stuck at the moment. Here are some details in case you need them:
my git bash $ pnpm install
Scope: all 238 workspace projects
. pnpm:devPreinstall$ node scripts/fix-pnpm-symlinks.js
└─ Done in 171ms
examples/blog-ecommerce | WARN deprecated [email protected]
examples/i18n-react | WARN deprecated [email protected]
examples/with-web3 | WARN deprecated [email protected]
packages/live-previews | WARN deprecated @refinedev/[email protected]
WARN deprecated @lerna/[email protected]: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.
packages/cli | WARN deprecated [email protected]
Progress: resolved 4480, reused 0, downloaded 0, added 0 |
So I could only 'successfully' run But if you delete the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @arndom, I've just pushed couple of commits including the changes in pnpm-lock.yaml
. I'll investigate the issue, it might be happening due to version changes in the packages and syncpack might been blocking the install 🤔
I've checked and saw that express
is not actually used in @refinedev/cli
anymore. I've removed the dependency and kept the other version updates as is.
Thank you for your contribution 🙏
express
to ^4.21.0
express
to ^4.21.0
PR Checklist
Please check if your PR fulfills the following requirements:
Bugs / Features
What is the current behavior?
What is the new behavior?
fixes #6321
Notes for reviewers