-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Timeseries insertion filters for close samples (#3228)
Support timeseries insertion filters for samples that are close to each other in time and value. Use the documented way to disable compression, i.e. `ENCODING UNCOMPRESSED` instead of `UNCOMPRESSED`. Polish the documentation related to timeseries. Align things needed around CI, to make sure all tests are actually executed. BREAKING CHANGES: 1. Remove the `uncompressed` flag from TS.ALTER, since compression of existing timeseries cannot be changed. This should not have been used, so there should be no real impact. 2. For the TS.ADD command (TimeSeriesCommands.add method): the `duplicate_policy` Python parameter that was mapping to `ON DUPLICATE` was now rewired to map to `DUPLICATE POLICY`. A new Python parameter called `on_duplicate` was added, that maps to `ON DUPLICATE`. The expected impact of this change is low.
- Loading branch information
Showing
6 changed files
with
980 additions
and
482 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -23,89 +23,91 @@ concurrency: | |
permissions: | ||
contents: read # to fetch code (actions/checkout) | ||
|
||
jobs: | ||
env: | ||
REDIS_STACK_IMAGE: redis/redis-stack-server:7.4.0-rc1 | ||
|
||
dependency-audit: | ||
name: Dependency audit | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v4 | ||
- uses: pypa/[email protected] | ||
with: | ||
inputs: requirements.txt dev_requirements.txt | ||
ignore-vulns: | | ||
GHSA-w596-4wvx-j9j6 # subversion related git pull, dependency for pytest. There is no impact here. | ||
jobs: | ||
dependency-audit: | ||
name: Dependency audit | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v4 | ||
- uses: pypa/[email protected] | ||
with: | ||
inputs: requirements.txt dev_requirements.txt | ||
ignore-vulns: | | ||
GHSA-w596-4wvx-j9j6 # subversion related git pull, dependency for pytest. There is no impact here. | ||
lint: | ||
name: Code linters | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v4 | ||
- uses: actions/setup-python@v5 | ||
with: | ||
python-version: 3.9 | ||
cache: 'pip' | ||
- name: run code linters | ||
run: | | ||
pip install -r dev_requirements.txt | ||
invoke linters | ||
lint: | ||
name: Code linters | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v4 | ||
- uses: actions/setup-python@v5 | ||
with: | ||
python-version: 3.9 | ||
cache: 'pip' | ||
- name: run code linters | ||
run: | | ||
pip install -r dev_requirements.txt | ||
invoke linters | ||
run-tests: | ||
runs-on: ubuntu-latest | ||
timeout-minutes: 60 | ||
strategy: | ||
max-parallel: 15 | ||
fail-fast: false | ||
matrix: | ||
python-version: ['3.8', '3.9', '3.10', '3.11', 'pypy-3.8', 'pypy-3.9'] | ||
test-type: ['standalone', 'cluster'] | ||
connection-type: ['hiredis', 'plain'] | ||
env: | ||
ACTIONS_ALLOW_UNSECURE_COMMANDS: true | ||
name: Python ${{ matrix.python-version }} ${{matrix.test-type}}-${{matrix.connection-type}} tests | ||
steps: | ||
- uses: actions/checkout@v4 | ||
- uses: actions/setup-python@v5 | ||
with: | ||
python-version: ${{ matrix.python-version }} | ||
cache: 'pip' | ||
- name: run tests | ||
run: | | ||
pip install -U setuptools wheel | ||
pip install -r requirements.txt | ||
pip install -r dev_requirements.txt | ||
if [ "${{matrix.connection-type}}" == "hiredis" ]; then | ||
pip install hiredis | ||
fi | ||
invoke devenv | ||
sleep 10 # time to settle | ||
invoke ${{matrix.test-type}}-tests | ||
run-tests: | ||
runs-on: ubuntu-latest | ||
timeout-minutes: 60 | ||
strategy: | ||
max-parallel: 15 | ||
fail-fast: false | ||
matrix: | ||
python-version: ['3.8', '3.9', '3.10', '3.11', 'pypy-3.8', 'pypy-3.9'] | ||
test-type: ['standalone', 'cluster'] | ||
connection-type: ['hiredis', 'plain'] | ||
env: | ||
ACTIONS_ALLOW_UNSECURE_COMMANDS: true | ||
name: Python ${{ matrix.python-version }} ${{matrix.test-type}}-${{matrix.connection-type}} tests | ||
steps: | ||
- uses: actions/checkout@v4 | ||
- uses: actions/setup-python@v5 | ||
with: | ||
python-version: ${{ matrix.python-version }} | ||
cache: 'pip' | ||
- name: run tests | ||
run: | | ||
pip install -U setuptools wheel | ||
pip install -r requirements.txt | ||
pip install -r dev_requirements.txt | ||
if [ "${{matrix.connection-type}}" == "hiredis" ]; then | ||
pip install hiredis | ||
fi | ||
invoke devenv | ||
sleep 10 # time to settle | ||
invoke ${{matrix.test-type}}-tests | ||
- uses: actions/upload-artifact@v4 | ||
if: success() || failure() | ||
with: | ||
name: pytest-results-${{matrix.test-type}}-${{matrix.connection-type}}-${{matrix.python-version}} | ||
path: '${{matrix.test-type}}*results.xml' | ||
- uses: actions/upload-artifact@v4 | ||
if: success() || failure() | ||
with: | ||
name: pytest-results-${{matrix.test-type}}-${{matrix.connection-type}}-${{matrix.python-version}} | ||
path: '${{matrix.test-type}}*results.xml' | ||
|
||
- name: Upload codecov coverage | ||
uses: codecov/codecov-action@v4 | ||
with: | ||
fail_ci_if_error: false | ||
- name: Upload codecov coverage | ||
uses: codecov/codecov-action@v4 | ||
with: | ||
fail_ci_if_error: false | ||
|
||
- name: View Test Results | ||
uses: dorny/test-reporter@v1 | ||
if: success() || failure() | ||
continue-on-error: true | ||
with: | ||
name: Test Results ${{matrix.python-version}} ${{matrix.test-type}}-${{matrix.connection-type}} | ||
path: '*.xml' | ||
reporter: java-junit | ||
list-suites: all | ||
list-tests: all | ||
max-annotations: 10 | ||
fail-on-error: 'false' | ||
- name: View Test Results | ||
uses: dorny/test-reporter@v1 | ||
if: success() || failure() | ||
continue-on-error: true | ||
with: | ||
name: Test Results ${{matrix.python-version}} ${{matrix.test-type}}-${{matrix.connection-type}} | ||
path: '*.xml' | ||
reporter: java-junit | ||
list-suites: all | ||
list-tests: all | ||
max-annotations: 10 | ||
fail-on-error: 'false' | ||
|
||
resp3_tests: | ||
resp3_tests: | ||
runs-on: ubuntu-latest | ||
strategy: | ||
fail-fast: false | ||
|
@@ -115,7 +117,7 @@ jobs: | |
connection-type: ['hiredis', 'plain'] | ||
protocol: ['3'] | ||
env: | ||
ACTIONS_ALLOW_UNSECURE_COMMANDS: true | ||
ACTIONS_ALLOW_UNSECURE_COMMANDS: true | ||
name: RESP3 [${{ matrix.python-version }} ${{matrix.test-type}}-${{matrix.connection-type}}] | ||
steps: | ||
- uses: actions/checkout@v4 | ||
|
@@ -136,7 +138,7 @@ jobs: | |
invoke ${{matrix.test-type}}-tests | ||
invoke ${{matrix.test-type}}-tests --uvloop | ||
build_and_test_package: | ||
build_and_test_package: | ||
name: Validate building and installing the package | ||
runs-on: ubuntu-latest | ||
needs: [run-tests] | ||
|
@@ -153,7 +155,7 @@ jobs: | |
run: | | ||
bash .github/workflows/install_and_test.sh ${{ matrix.extension }} | ||
install_package_from_commit: | ||
install_package_from_commit: | ||
name: Install package from commit hash | ||
runs-on: ubuntu-latest | ||
strategy: | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.