fixed random instance id and sets not showing up

Signed-off-by: Elena Kolevska <[email protected]>

Author: elena-kolevska

.env.example

@@ -26,7 +26,7 @@ TEST_TARGET_OPS_PER_SECOND=
 TEST_WORKLOAD_PROFILE=basic_rw
 TEST_OPERATIONS=SET,GET
 TEST_OPERATION_WEIGHTS=
-TEST_KEY_PREFIX=test_key
+TEST_KEY_PREFIX=rw_test
 TEST_KEY_RANGE=10000
 TEST_VALUE_SIZE_MIN=100
 TEST_VALUE_SIZE_MAX=1000
@@ -61,7 +61,7 @@ OTEL_RESOURCE_ATTRIBUTES=service.name=redis-py-test-app,service.version=1.0.0
 
 # Multi-App Identification
 APP_NAME=python
-INSTANCE_ID=python-redis-test-1
+INSTANCE_ID=
 
 # Output Configuration
 OUTPUT_FILE=

README.md

@@ -287,7 +287,7 @@ TEST_THREADS_PER_CLIENT=3
 
 # Application Identity
 APP_NAME=python-dev
-INSTANCE_ID=dev-instance-1
+INSTANCE_ID=  # Auto-generated random ID if not specified
 VERSION=v1.0.0
 
 # OpenTelemetry

cli.py

@@ -87,7 +87,7 @@ def cli():
 @click.option('--otel-service-name', default=lambda: get_env_or_default('OTEL_SERVICE_NAME', 'redis-load-test'), help='OpenTelemetry service name')
 @click.option('--otel-export-interval', type=int, default=lambda: get_env_or_default('OTEL_EXPORT_INTERVAL', 5000, int), help='OpenTelemetry export interval in milliseconds')
 @click.option('--app-name', default=lambda: get_env_or_default('APP_NAME', 'python'), help='Application name for multi-app filtering (python, go, java, etc.)')
-@click.option('--instance-id', default=lambda: get_env_or_default('INSTANCE_ID', None), help='Unique instance identifier')
+@click.option('--instance-id', default=lambda: get_env_or_default('INSTANCE_ID', None), help='Unique instance identifier (auto-generated if not provided)')
 @click.option('--version', default=lambda: get_env_or_default('VERSION', None), help='Version identifier (defaults to redis-py package version)')
 @click.option('--output-file', default=lambda: get_env_or_default('OUTPUT_FILE', None), help='Output file for metrics export (JSON)')
 @click.option('--quiet', is_flag=True, default=lambda: get_env_or_default('QUIET', False, bool), help='Suppress periodic stats output')

config.py

@@ -226,7 +226,7 @@ def get_profile(profile_name: str) -> WorkloadConfig:
                     "operation_weights": {"SET": 0.4, "GET": 0.5, "DEL": 0.1},
                     "valueSize": 100,
                     "iterationCount": 1000,
-                    "keyPrefix": "test_key",
+                    "keyPrefix": "rw_test",
                     "keyRange": 10000
                 }
             ),

metrics.py

@@ -9,6 +9,7 @@
 import statistics
 import json
 import os
+import uuid
 
 # Prometheus imports (for backward compatibility)
 from prometheus_client import Counter, Histogram, Gauge, start_http_server
@@ -57,7 +58,7 @@ def __init__(self, enable_prometheus: bool = True, prometheus_port: int = 8000,
         self.service_version = service_version
         self.otel_export_interval_ms = otel_export_interval_ms
         self.app_name = app_name
-        self.instance_id = instance_id or f"{app_name}-{int(time.time())}"
+        self.instance_id = instance_id if instance_id and instance_id.strip() else f"{app_name}-{str(uuid.uuid4())[:8]}"
         self.version = version or "unknown"
 
         # Thread-safe metrics storage
@@ -118,9 +119,9 @@ def _setup_opentelemetry(self):
             )
 
             self.otel_operation_duration = self.meter.create_histogram(
-                name="redis_operation_duration_ms",
+                name="redis_operation_duration",
                 description="Duration of Redis operations in milliseconds",
-                unit="1"
+                unit="ms"
             )
 
             self.otel_connections_counter = self.meter.create_counter(

observability/grafana/provisioning/dashboards/redis-test-dashboard.json

@@ -171,13 +171,13 @@
       },
       "targets": [
         {
-          "expr": "histogram_quantile(0.95, sum(rate(redis_operation_duration_ms_bucket{app_name=~\"$app_name\", instance_id=~\"$instance_id\", operation=~\"$operation\", version=~\"$version\"}[5m])) by (operation, le))",
+          "expr": "histogram_quantile(0.95, sum(rate(redis_operation_duration_bucket{app_name=~\"$app_name\", instance_id=~\"$instance_id\", operation=~\"$operation\", version=~\"$version\"}[5m])) by (operation, le))",
           "interval": "",
           "legendFormat": "95th percentile - {{operation}}",
           "refId": "A"
         },
         {
-          "expr": "histogram_quantile(0.50, sum(rate(redis_operation_duration_ms_bucket{app_name=~\"$app_name\", instance_id=~\"$instance_id\", operation=~\"$operation\", version=~\"$version\"}[5m])) by (operation, le))",
+          "expr": "histogram_quantile(0.50, sum(rate(redis_operation_duration_bucket{app_name=~\"$app_name\", instance_id=~\"$instance_id\", operation=~\"$operation\", version=~\"$version\"}[5m])) by (operation, le))",
           "interval": "",
           "legendFormat": "50th percentile - {{operation}}",
           "refId": "B"
@@ -258,7 +258,7 @@
       },
       "targets": [
         {
-          "expr": "sum(rate(redis_operation_duration_ms_sum{app_name=~\"$app_name\", instance_id=~\"$instance_id\", operation=~\"$operation\", version=~\"$version\"}[5m])) by (operation) / sum(rate(redis_operation_duration_ms_count{app_name=~\"$app_name\", instance_id=~\"$instance_id\", operation=~\"$operation\", version=~\"$version\"}[5m])) by (operation)",
+          "expr": "sum(rate(redis_operation_duration_sum{app_name=~\"$app_name\", instance_id=~\"$instance_id\", operation=~\"$operation\", version=~\"$version\"}[5m])) by (operation) / sum(rate(redis_operation_duration_count{app_name=~\"$app_name\", instance_id=~\"$instance_id\", operation=~\"$operation\", version=~\"$version\"}[5m])) by (operation)",
           "interval": "",
           "legendFormat": "Average - {{operation}}",
           "refId": "A"

workloads.py

@@ -39,7 +39,7 @@ def _generate_key(self) -> str:
                 key_id = self._key_counter
                 self._key_counter += 1
 
-            key_prefix = self.config.get_option("keyPrefix", "test_key")
+            key_prefix = self.config.get_option("keyPrefix", "rw_test")
             return f"{key_prefix}:{key_id}"
 
     def _generate_value(self) -> str: