add failure missing test samples #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnunyez
changed the title
nocturnalastro
approved these changes
Oct 27, 2023
jnunyez
force-pushed
the
add-failure
branch
2 times, most recently
from
15791e8 to
af2e2ba
Compare
|
Updated to limit test case failure for phc2sys and ts2phc analyzer. Tested and ready to merge. We are gonna allow ubxtool, dpll collector to miss samples since that does not affect synchronization performance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds new class of test result failure where there is a sufficient amount of test samples to compute the intented metric but some samples were lost during the data gathering (e.g., in the case of ts2phc NMEA sentences dont arrive to E810 CVL).
We want to report a failure stating
missing test samplesand produce the plot (to aproximately have an idea instants where data was missing) and get the analysis of the data we could capture if there are more than mininimal set of samples.