add failure missing test samples

redhat-partner-solutions · Oct 27, 2023 · af2e2ba · af2e2ba
1 parent c64b213
commit af2e2ba
Show file tree

Hide file tree

Showing 5 changed files with 91 additions and 0 deletions.
diff --git a/src/vse_sync_pp/analyzers/analyzer.py b/src/vse_sync_pp/analyzers/analyzer.py
@@ -144,6 +144,13 @@ def _timestamp_from_dec(self, dec):
         # relative time
         return dec
 
+    @staticmethod
+    def _check_missing_samples(data, result, reason):
+        if reason is None:
+            if len(data.timestamp.diff().astype(float).round(0).tail(-1).unique()) > 1:
+                return (False, "missing test samples")
+        return result, reason
+
     @property
     def result(self):
         """The boolean result from this analyzer's test of the collected data"""
@@ -379,6 +386,8 @@ def _test_common(self, data):
             return (False, "short test duration")
         if len(data) - 1 < self._duration_min:
             return (False, "short test samples")
+        if len(data.timestamp.diff().astype(float).round(0).tail(-1).unique()) > 1:
+            return (False, "missing test samples")
         return None
 
     def _explain_common(self, data):

diff --git a/src/vse_sync_pp/analyzers/phc2sys.py b/src/vse_sync_pp/analyzers/phc2sys.py
@@ -13,16 +13,25 @@ class TimeErrorAnalyzer(TimeErrorAnalyzerBase):
     parser = id_
     locked = frozenset({'s2'})
 
+    def test(self, data):
+        return self._check_missing_samples(data, *super().test(data))
+
 
 class TimeDeviationAnalyzer(TimeDeviationAnalyzerBase):
     """Analyze time deviation"""
     id_ = 'phc2sys/time-deviation'
     parser = 'phc2sys/time-error'
     locked = frozenset({'s2'})
 
+    def test(self, data):
+        return self._check_missing_samples(data, *super().test(data))
+
 
 class MaxTimeIntervalErrorAnalyzer(MaxTimeIntervalErrorAnalyzerBase):
     """Analyze max time interval error"""
     id_ = 'phc2sys/mtie'
     parser = 'phc2sys/time-error'
     locked = frozenset({'s2'})
+
+    def test(self, data):
+        return self._check_missing_samples(data, *super().test(data))
diff --git a/src/vse_sync_pp/analyzers/ts2phc.py b/src/vse_sync_pp/analyzers/ts2phc.py
@@ -12,16 +12,25 @@ class TimeErrorAnalyzer(TimeErrorAnalyzerBase):
     parser = id_
     locked = frozenset({'s2'})
 
+    def test(self, data):
+        return self._check_missing_samples(data, *super().test(data))
+
 
 class TimeDeviationAnalyzer(TimeDeviationAnalyzerBase):
     """Analyze time deviation"""
     id_ = 'ts2phc/time-deviation'
     parser = 'ts2phc/time-error'
     locked = frozenset({'s2'})
 
+    def test(self, data):
+        return self._check_missing_samples(data, *super().test(data))
+
 
 class MaxTimeIntervalErrorAnalyzer(MaxTimeIntervalErrorAnalyzerBase):
     """Analyze max time interval error"""
     id_ = 'ts2phc/mtie'
     parser = 'ts2phc/time-error'
     locked = frozenset({'s2'})
+
+    def test(self, data):
+        return self._check_missing_samples(data, *super().test(data))
diff --git a/tests/vse_sync_pp/analyzers/test_phc2sys.py b/tests/vse_sync_pp/analyzers/test_phc2sys.py
@@ -185,6 +185,38 @@ class TestTimeErrorAnalyzer(TestCase, metaclass=AnalyzerTestBuilder):
                 },
             },
         },
+        {
+            'requirements': 'workload/RAN',
+            'parameters': {
+                'time-error-limit/%': 100,
+                'transient-period/s': 1,
+                'min-test-duration/s': 4,
+            },
+            'rows': (
+                TERR(Decimal(0), 0, 's2', 620),
+                TERR(Decimal(1), 0, 's2', 620),
+                TERR(Decimal(2), 0, 's2', 620),
+                TERR(Decimal(3), 0, 's2', 620),
+                # oops, missing sample
+                TERR(Decimal(5), 0, 's2', 620),
+                TERR(Decimal(6), 0, 's2', 620),
+            ),
+            'result': False,
+            'reason': "missing test samples",
+            'timestamp': Decimal(1),
+            'duration': Decimal(5),
+            'analysis': {
+                'terror': {
+                    'units': 'ns',
+                    'min': 0,
+                    'max': 0,
+                    'range': 0,
+                    'mean': 0,
+                    'stddev': 0,
+                    'variance': 0,
+                },
+            },
+        },
         {
             'requirements': 'workload/RAN',
             'parameters': {

diff --git a/tests/vse_sync_pp/analyzers/test_ts2phc.py b/tests/vse_sync_pp/analyzers/test_ts2phc.py
@@ -185,6 +185,38 @@ class TestTimeErrorAnalyzer(TestCase, metaclass=AnalyzerTestBuilder):
                 },
             },
         },
+        {
+            'requirements': 'G.8272/PRTC-A',
+            'parameters': {
+                'time-error-limit/%': 100,
+                'transient-period/s': 1,
+                'min-test-duration/s': 4,
+            },
+            'rows': (
+                TERR(Decimal(0), 0, 's2'),
+                TERR(Decimal(1), 0, 's2'),
+                TERR(Decimal(2), 0, 's2'),
+                TERR(Decimal(3), 0, 's2'),
+                # oops, missing sample
+                TERR(Decimal(5), 0, 's2'),
+                TERR(Decimal(6), 0, 's2'),
+            ),
+            'result': False,
+            'reason': "missing test samples",
+            'timestamp': Decimal(1),
+            'duration': Decimal(5),
+            'analysis': {
+                'terror': {
+                    'units': 'ns',
+                    'min': 0,
+                    'max': 0,
+                    'range': 0,
+                    'mean': 0,
+                    'stddev': 0,
+                    'variance': 0,
+                },
+            },
+        },
         {
             'requirements': 'G.8272/PRTC-A',
             'parameters': {