-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
item-23-147 #409
item-23-147 #409
Conversation
2a93249
to
567b804
Compare
@redhat-documentation/ccs-style-council . Please review the following PR. |
supplementary_style_guide/glossary_terms_conventions/general_conventions/b.adoc
Outdated
Show resolved
Hide resolved
supplementary_style_guide/glossary_terms_conventions/general_conventions/s.adoc
Outdated
Show resolved
Hide resolved
supplementary_style_guide/glossary_terms_conventions/general_conventions/s.adoc
Outdated
Show resolved
Hide resolved
567b804
to
e67e88d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment
supplementary_style_guide/glossary_terms_conventions/general_conventions/s.adoc
Outdated
Show resolved
Hide resolved
4ec966f
to
77e3b93
Compare
supplementary_style_guide/glossary_terms_conventions/general_conventions/s.adoc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
supplementary_style_guide/glossary_terms_conventions/general_conventions/s.adoc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few last things
supplementary_style_guide/glossary_terms_conventions/general_conventions/b.adoc
Outdated
Show resolved
Hide resolved
supplementary_style_guide/glossary_terms_conventions/general_conventions/s.adoc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Considerations
I updated the spec file entry based on the following sources:
I noticed that the Fedora docs use the term "RPM spec file", but the RPM owns the spec file so I made such references into possessive constrcuts.
Issue
Closes number 23 in #147
Preview link
https://file.emea.redhat.com/dfitzmau/item-23-147/main.html#_s