Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

item-23-147 #409

Merged
merged 1 commit into from
Oct 17, 2023
Merged

item-23-147 #409

merged 1 commit into from
Oct 17, 2023

Conversation

dfitzmau
Copy link
Contributor

@dfitzmau dfitzmau commented Sep 28, 2023

Screenshot from 2023-09-28 17-15-32

Considerations

I updated the spec file entry based on the following sources:

I noticed that the Fedora docs use the term "RPM spec file", but the RPM owns the spec file so I made such references into possessive constrcuts.

Issue

Closes number 23 in #147

Preview link

https://file.emea.redhat.com/dfitzmau/item-23-147/main.html#_s

@dfitzmau
Copy link
Contributor Author

@redhat-documentation/ccs-style-council . Please review the following PR.

Copy link
Collaborator

@mportman12 mportman12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment

@dfitzmau dfitzmau force-pushed the item-23-147 branch 2 times, most recently from 4ec966f to 77e3b93 Compare October 2, 2023 13:53
mportman12
mportman12 previously approved these changes Oct 2, 2023
Copy link
Collaborator

@mportman12 mportman12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bburt-rh
bburt-rh previously approved these changes Oct 2, 2023
Copy link
Collaborator

@bergerhoffer bergerhoffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few last things

@bergerhoffer bergerhoffer added the Glossary entry Topics that add or modify glossary entries label Oct 2, 2023
Copy link
Collaborator

@bergerhoffer bergerhoffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@mportman12 mportman12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@sbmetz sbmetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mportman12 mportman12 merged commit 4e9a51a into redhat-documentation:main Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Glossary entry Topics that add or modify glossary entries
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants