Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adding since to S file #406

Merged
merged 4 commits into from
Oct 4, 2023
Merged

feat: adding since to S file #406

merged 4 commits into from
Oct 4, 2023

Conversation

CBID2
Copy link
Contributor

@CBID2 CBID2 commented Sep 27, 2023 •
edited
Loading

Description of Changes

This PR turns the "because" entry into "since" and places the revised entry into the S file

Related Issue

Closes number 10 in #147

@CBID2 CBID2 mentioned this pull request Sep 27, 2023
Open
27 tasks
@bergerhoffer
Copy link
Collaborator

So, because "since" is already included in the IBM style guide, I think that the correct resolution for number 10 is to just remove the "because" entry. @bredamc Do you agree?

@bergerhoffer bergerhoffer self-requested a review September 28, 2023 17:08
@bergerhoffer bergerhoffer added the Glossary entry Topics that add or modify glossary entries label Sep 28, 2023
@mportman12
Copy link
Collaborator

I agree with @bergerhoffer

@bredamc
Copy link
Contributor

bredamc commented Sep 28, 2023

Yes, I agree -- I added a comment to that effect in the original issue this morning (apologies for putting my comment in the wrong place!) :)

@CBID2
Copy link
Contributor Author

CBID2 commented Sep 28, 2023 •
edited
Loading

So, because "since" is already included in the IBM style guide, I think that the correct resolution for number 10 is to just remove the "because" entry. @bredamc Do you agree?

Ok so, I just need to remove the since entry that I created @bergerhoffer?

@bergerhoffer
Copy link
Collaborator

Ok so, I just need to remove the since entry that I created @bergerhoffer?

@CBID2 Yep that's right! Just try to leave line 430 there (the one that says "// EAP: Added "In Red Hat JBoss Enterprise Application Platform,").

Thanks!

@CBID2
Copy link
Contributor Author

CBID2 commented Sep 28, 2023

Ok so, I just need to remove the since entry that I created @bergerhoffer?

@CBID2 Yep that's right! Just try to leave line 430 there (the one that says "// EAP: Added "In Red Hat JBoss Enterprise Application Platform,").

Thanks!

Made the change @bergerhoffer! :)

mportman12
mportman12 requested changes Oct 2, 2023
View reviewed changes
supplementary_style_guide/glossary_terms_conventions/general_conventions/s.adoc Outdated
@@ -428,6 +428,8 @@ Use all lower case, unless used in a title or at the beginning of a sentence.
*See also*: xref:logical-topology[logical topology], xref:physical-topology[physical topology]

// EAP: Added "In Red Hat JBoss Enterprise Application Platform,"

*See also*:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove, as there's already a "see also" for this entry.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done @mportman12

@CBID2 CBID2 requested a review from mportman12 October 3, 2023 21:34
mportman12
mportman12 approved these changes Oct 3, 2023
View reviewed changes
Copy link
Collaborator

@mportman12 mportman12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IngridT1
Copy link

IngridT1 commented Oct 4, 2023

LGTM

@bburt-rh
Copy link
Contributor

bburt-rh commented Oct 4, 2023

lgtm. Merging

@bburt-rh bburt-rh merged commit 18ce8a9 into redhat-documentation:main Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bburt-rh bburt-rh bburt-rh approved these changes

@mportman12 mportman12 mportman12 approved these changes

@IngridT1 IngridT1 IngridT1 approved these changes

@bergerhoffer bergerhoffer Awaiting requested review from bergerhoffer

Assignees
No one assigned
Labels
Glossary entry Topics that add or modify glossary entries
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@CBID2 @bergerhoffer @mportman12 @bredamc @IngridT1 @bburt-rh