-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rephrasing sentences #375
Rephrasing sentences #375
Conversation
Hi @CBID2. I think that things have gotten rearranged since this issue was created. It's not the place you updated, it's this sentence:
The suggestion is to change it to:
|
As for the second item, I wouldn't worry about that one. I'm not sure what "This" really refers, to. We'd have to contact the person who added the suggestion, or just add a different example. So i think it's fine to just take care of the first part of item 8. Thanks! |
Ohh thanks for clarifying @bergerhoffer |
Made the changes @bergerhoffer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Will need 2 more approvals from our team, then we'll merge.
The merge-base changed after approval.
The merge-base changed after approval.
Something funny was going on with GitHub where it wasn't accepting my approval. It immediately said that the "merge-base changed after approval" (it didn't). After closing and reopening the PR to see if that would help (based on googling and finding https://github.com/orgs/community/discussions/58535), I'm now seeing some additional changes in this PR (all of the terms you removed in another PR are being added back in). Closing and reopening again to see if that helps. If not, we'll have to figure out something else |
@CBID2 I'm sorry it seems like something weird is going on - maybe a bug with GitHub, but not sure. We could try to debug it, but the easier thing would probably be to just close this PR and open a new PR with the one line change you intended. Let me know if you're okay with doing that. Thanks! |
That's fine @bergerhoffer! :) |
Changes made
This PR rephrases part of the sentence displayed via the second bullet in the links subsection of the guide.
Issue
Closes #147
Note to Reviewers
Hi @bergerhoffer! :) I could not solve the second part of Task 8 due to not having access to IBM. Is there a way you can help me?