Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rephrasing sentences #375

Closed
wants to merge 7 commits into from

Conversation

CBID2
Copy link
Contributor

@CBID2 CBID2 commented Aug 4, 2023

Changes made

This PR rephrases part of the sentence displayed via the second bullet in the links subsection of the guide.

Issue

Closes #147

Note to Reviewers

Hi @bergerhoffer! :) I could not solve the second part of Task 8 due to not having access to IBM. Is there a way you can help me?

@CBID2 CBID2 mentioned this pull request Aug 7, 2023
@bergerhoffer
Copy link
Collaborator

Hi @CBID2.

I think that things have gotten rearranged since this issue was created. It's not the place you updated, it's this sentence:

* Call out that this is a Knowledgebase article when _not_ using running text.

The suggestion is to change it to:

* When not using running text, call out that this is a Knowledgebase article.

@bergerhoffer
Copy link
Collaborator

As for the second item, I wouldn't worry about that one. I'm not sure what "This" really refers, to. We'd have to contact the person who added the suggestion, or just add a different example.

So i think it's fine to just take care of the first part of item 8. Thanks!

@bergerhoffer bergerhoffer added the General update General updates to the guide or repo label Aug 7, 2023
@CBID2
Copy link
Contributor Author

CBID2 commented Aug 7, 2023

Hi @CBID2.

I think that things have gotten rearranged since this issue was created. It's not the place you updated, it's this sentence:


* Call out that this is a Knowledgebase article when _not_ using running text.

The suggestion is to change it to:


* When not using running text, call out that this is a Knowledgebase article.

Ohh thanks for clarifying @bergerhoffer

@CBID2
Copy link
Contributor Author

CBID2 commented Aug 11, 2023

Made the changes @bergerhoffer

bergerhoffer
bergerhoffer previously approved these changes Aug 14, 2023
Copy link
Collaborator

@bergerhoffer bergerhoffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Will need 2 more approvals from our team, then we'll merge.

@CBID2 CBID2 dismissed bergerhoffer’s stale review August 14, 2023 15:44

The merge-base changed after approval.

bergerhoffer
bergerhoffer previously approved these changes Aug 14, 2023
@bergerhoffer bergerhoffer reopened this Aug 14, 2023
@bergerhoffer bergerhoffer dismissed their stale review August 14, 2023 15:49

The merge-base changed after approval.

@bergerhoffer
Copy link
Collaborator

Something funny was going on with GitHub where it wasn't accepting my approval. It immediately said that the "merge-base changed after approval" (it didn't).

After closing and reopening the PR to see if that would help (based on googling and finding https://github.com/orgs/community/discussions/58535), I'm now seeing some additional changes in this PR (all of the terms you removed in another PR are being added back in).

Closing and reopening again to see if that helps. If not, we'll have to figure out something else

@bergerhoffer
Copy link
Collaborator

@CBID2 I'm sorry it seems like something weird is going on - maybe a bug with GitHub, but not sure. We could try to debug it, but the easier thing would probably be to just close this PR and open a new PR with the one line change you intended. Let me know if you're okay with doing that. Thanks!

@CBID2
Copy link
Contributor Author

CBID2 commented Aug 14, 2023

@CBID2 I'm sorry it seems like something weird is going on - maybe a bug with GitHub, but not sure. We could try to debug it, but the easier thing would probably be to just close this PR and open a new PR with the one line change you intended. Let me know if you're okay with doing that. Thanks!

That's fine @bergerhoffer! :)

@CBID2 CBID2 closed this Aug 14, 2023
@CBID2 CBID2 deleted the rephrasing-sentences branch August 14, 2023 15:56
@CBID2 CBID2 restored the rephrasing-sentences branch August 14, 2023 16:22
@CBID2 CBID2 reopened this Aug 14, 2023
@CBID2 CBID2 closed this Aug 14, 2023
@CBID2 CBID2 deleted the rephrasing-sentences branch August 14, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
General update General updates to the guide or repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix various style issues and typos throughout the guide
2 participants