-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove copy of podman CLI implementation and migrate to new API when implemented #44
Comments
@benoitf where package with API definition should be placed. Should it be done the same way as for @podman-destop/api? |
yes probably we should have it part of the podman extension and published on each release probably another package or refactor the podman extension to have multiple folders (not sure it'll work fine to automatically load the extension using that way) |
@benoitf Would implementing it as Here is an implementation https://github.com/containers/podman-desktop/compare/main...dgolovin:i5990?expand=1 |
@dgolovin there should be no podman module ( no changes in the extension loader file) it's the other extensions that can get the extension object from |
@benoitf I can do it in similar fashion as #7961, but that will:
For external contributions that would be required, podman extension is built-in and always present why not expose it in @podamn-desktop/api? |
because the podman extension might not always be a default extension. Also users can disable the extension. And it should always be within extensions. |
Current implementation is copied form podman extension and should be removed when podman desktop has new API to call podman commands podman-desktop/podman-desktop#5990.
The text was updated successfully, but these errors were encountered: