Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension should not register sign in requests or run any subscription related commands #152

Open
3 tasks
dgolovin opened this issue Jun 4, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@dgolovin
Copy link
Collaborator

dgolovin commented Jun 4, 2024

In latest release the Red Hat SSO extension itself adds so called Authentication request which is visible on:

  1. Authentication settings page
  2. Buddy Icon context menu in activity bar
  3. Status bar as a hat

When one uses any of the mentioned controls the ext redirects to the default browser for authentication and after successful login 1. Creates registry.redhat.com account in Registries settings
2. Activates developer subscription in current active podman VM

That was done to simplify implementation and user experience for summit. With no dependent extension published that works just fine. But when OpenShift Local extension start using Red Hat SSO extension to let user to pull pull-secret without copy paste commands that executed after sign in look a bit out of context. Same can be told about developer sandbox connection configuration, when extension needs the SSO token to talk to sandbox registration service and has nothing to do with building Bootable Images based on RHEL.

Considering above problems the SSO Extension should not:

  1. Add authentication request
  2. Assume registry access configuration is required
  3. Or subscription activation is required

All three item should be delegated to dependent extensions because SSO extension is not aware of the reason for authentication request.

Related issues:

@dgolovin dgolovin added the enhancement New feature or request label Jun 4, 2024
@dgolovin dgolovin changed the title Extension should not reqister sign In requests or any subscription related commands Extension should not register sign In requests or any subscription related commands Jun 4, 2024
@jeffmaury jeffmaury removed their assignment Jun 4, 2024
@dgolovin dgolovin changed the title Extension should not register sign In requests or any subscription related commands Extension should not register sign In requests or run any subscription related commands Jun 5, 2024
@dgolovin dgolovin changed the title Extension should not register sign In requests or run any subscription related commands Extension should not register sign in requests or run any subscription related commands Jul 5, 2024
@jeffmaury
Copy link
Member

As per discussion with @slemeur this is not a priority, we can keep Podman Machine as a requirement, so moving to Postponed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants