Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

command for opening terminal in a container odo terminal #6731

Open
3 tasks
kadel opened this issue Apr 12, 2023 · 6 comments
Open
3 tasks

command for opening terminal in a container odo terminal #6731

kadel opened this issue Apr 12, 2023 · 6 comments
Labels
kind/user-story An issue of user-story kind lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/Medium Nice to have issue. Getting it done before priority changes would be great.

Comments

@kadel
Copy link
Member

kadel commented Apr 12, 2023

/kind user-story

User Story

As an odo user, I want to be able to open a terminal in the container with my application So that I can run commands in the container and debug application.

Acceptance Criteria

  • odo terminal command should automatically open bash/sh in the container where the application is currently running
  • odo terminal --container mycontainer should open terminal to a container named mycontainer
  • if there are multiple containers and the user doesn't specify one with --container flag odo should error out and list all container names and tell the user to specify one.
@openshift-ci openshift-ci bot added the kind/user-story An issue of user-story kind label Apr 12, 2023
@github-actions github-actions bot added the needs-triage Indicates an issue or PR lacks a `triage/*` and requires one. label Apr 12, 2023
@rm3l rm3l removed the needs-triage Indicates an issue or PR lacks a `triage/*` and requires one. label Jun 29, 2023
@rm3l
Copy link
Member

rm3l commented Jul 6, 2023

Grooming (Jul 6, 2023)

  • The shell (bash, sh, ...) should be a flag, defaulting to bash
  • -it (input / TTY) should be set automatically for the moment (as it is for now for odo run)
  • --container is the name of the container component in the Devfile
  • Dynamically create a new exec command in the Devfile in memory with the shell command executed (default value for workingDir is /projects):
- exec:
    commandLine: bash
    component: runtime
    workingDir: ${PROJECT_SOURCE}
  id: connect

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

A friendly reminder that this issue had no activity for 90 days. Stale issues will be closed after an additional 30 days of inactivity.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 5, 2023
@rm3l
Copy link
Member

rm3l commented Oct 5, 2023

/remove-lifecycle stale
/priority Medium

Still relevant, and bumping priority to Medium because it came as a feature request following a recent talk at a local meetup.

@openshift-ci openshift-ci bot added priority/Medium Nice to have issue. Getting it done before priority changes would be great. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 5, 2023
@AgentK9
Copy link

AgentK9 commented Oct 18, 2023

Would really like this feature! commenting for visibility.

@AgentK9
Copy link

AgentK9 commented Oct 18, 2023

Another idea: have an option that allows certain commands to result in an interactive shell instead of just exiting (use case would be something like odo run python which would drop you into the python shell in your container)

Copy link
Contributor

A friendly reminder that this issue had no activity for 90 days. Stale issues will be closed after an additional 30 days of inactivity.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 17, 2024
@rm3l rm3l added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/user-story An issue of user-story kind lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/Medium Nice to have issue. Getting it done before priority changes would be great.
Projects
Status: No status
Development

No branches or pull requests

3 participants