Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Web UI Sign-up Optional #469

Closed
hollowec opened this issue Dec 2, 2020 · 7 comments
Closed

Make Web UI Sign-up Optional #469

hollowec opened this issue Dec 2, 2020 · 7 comments
Assignees

Comments

@hollowec
Copy link

hollowec commented Dec 2, 2020

Hi,

Would it be possible to make the Web-UI signup functionality optional? Perhaps a value that can be overidden during the helm installation?

@tiborsimko
Copy link
Member

BTW while we are at this, perhaps we can style the sign-up page a bit differently, because currently the two pages (sign-up and sign-in) are styled IIRC exactly the same, so users may not even notice where they are.

We can leave only one big sign-in button with a small text underneath "If you do not have an account yet, please sign up here" (and the link will bring people to a dedicated sign-up page, where we could later have captcha and email verification and stuff).

And, for this ticket at hand, the text under sign-in would simply read "If you don't have an account yet, please contact REANA administrators" with a mailto for site admins.

So the sign-in UI design would be similar for the two cases.

@mvidalgarcia
Copy link
Member

Discussed offline:

Keep the sign-up form always and enable Invenio-Accounts email confirmation so the account is only usable once confirmed. After that, the user must request the token as usual.

@hollowec would this fulfill your needs?

@hollowec
Copy link
Author

Hi @mvidalgarcia , that would help a lot, but I would prefer to also have the option to disable the sign-up completely if possible.

@mvidalgarcia
Copy link
Member

Hi @mvidalgarcia , that would help a lot, but I would prefer to also have the option to disable the sign-up completely if possible.

The problem with this approach is that,

  • a) At the moment, as you well mentioned on Gitter, it's not possible to set a password to newly created users via reana-admin;
  • b) If we implement this, the safest way to do it would be autogenerating a random password for the new user. Then, it'd responsibility of the admin to send this password to the user, with the safety problems that it involves;
  • c) We still don't have the possibility for users to change their password, so that autogenerated password would be compromised from the very first moment. We will have to make the changing password available before.

If enabling email confirmation would already help a lot, we will most likely implement this first, as it seems the easiest/fastest/most common approach to us, and then we will consider applying the rest of the functionalities. I'm pretty sure that some of them such as changing passwords will come sooner or later.

Thanks so much for your input!

@hollowec
Copy link
Author

Hi @mvidalgarcia, OK sounds good, thanks! Can captcha be enabled for sign-up as well?

@mvidalgarcia
Copy link
Member

Hi @mvidalgarcia, OK sounds good, thanks! Can captcha be enabled for sign-up as well?

We will definitely explore this option in the future.

audrium added a commit to audrium/reana-ui that referenced this issue Dec 17, 2020
audrium added a commit to audrium/reana-ui that referenced this issue Dec 17, 2020
audrium added a commit to audrium/reana that referenced this issue Dec 17, 2020
audrium added a commit to audrium/reana-server that referenced this issue Dec 17, 2020
audrium added a commit to audrium/reana-commons that referenced this issue Dec 17, 2020
audrium added a commit to audrium/reana-server that referenced this issue Dec 17, 2020
audrium added a commit to audrium/reana-commons that referenced this issue Dec 17, 2020
audrium added a commit to audrium/reana that referenced this issue Jan 4, 2021
audrium added a commit to audrium/reana that referenced this issue Jan 4, 2021
audrium added a commit to audrium/reana that referenced this issue Jan 4, 2021
audrium added a commit to audrium/reana-server that referenced this issue Jan 4, 2021
audrium added a commit to audrium/reana-commons that referenced this issue Jan 4, 2021
audrium added a commit to audrium/reana that referenced this issue Jan 4, 2021
audrium added a commit to audrium/reana-ui that referenced this issue Jan 4, 2021
audrium added a commit to audrium/reana-server that referenced this issue Jan 5, 2021
audrium added a commit to audrium/reana-server that referenced this issue Jan 5, 2021
@mvidalgarcia mvidalgarcia removed their assignment Feb 8, 2021
mvidalgarcia added a commit to mvidalgarcia/reana-ui that referenced this issue Feb 15, 2021
* maint-0.7:
  release: 0.7.2
  auth: hide SSO sign up notification
  ui: added privacy policy page with RoPo content
  auth: adjust success messages to user confirmation
  auth: clear notifications before sign in/up
  auth: display server confirmation success message
  auth: display notification when signing up via SSO
  auth: add route to handle email confirmation
  auth: show proper notifications when signing in/up
  ui: make notifications more generic
  ui: control signup form visibility with configs
  ui: show more meaningful errors
  ui: split Signin component into two separate components addresses reanahub/reana#469
mvidalgarcia added a commit to mvidalgarcia/reana-ui that referenced this issue Feb 15, 2021
* maint-0.7:
  release: 0.7.2
  auth: hide SSO sign up notification
  ui: added privacy policy page with RoPo content
  auth: adjust success messages to user confirmation
  auth: clear notifications before sign in/up
  auth: display server confirmation success message
  auth: display notification when signing up via SSO
  auth: add route to handle email confirmation
  auth: show proper notifications when signing in/up
  ui: make notifications more generic
  ui: control signup form visibility with configs
  ui: show more meaningful errors
  ui: split Signin component into two separate components addresses reanahub/reana#469
@mvidalgarcia
Copy link
Member

Closing this as the main functionality has been implemented and published in the 0.7.2 release.

Separate issue created for the captcha implementation: reanahub/reana-ui#177

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants