Use config.stash to store the results path

Author: dmtucker

src/pytest_mypy.py

@@ -14,6 +14,9 @@
 
 mypy_argv = []
 nodeid_name = "mypy"
+stash_keys = {
+    "mypy_results_path": pytest.StashKey[Path](),
+}
 terminal_summary_title = "mypy"
 
 
@@ -80,18 +83,18 @@ def pytest_configure(config):
         # Subsequent MypyItems will see the file exists,
         # and they will read the parsed results.
         with NamedTemporaryFile(delete=True) as tmp_f:
-            config._mypy_results_path = tmp_f.name
+            config.stash[stash_keys["mypy_results_path"]] = Path(tmp_f.name)
 
         # If xdist is enabled, then the results path should be exposed to
         # the workers so that they know where to read parsed results from.
         if config.pluginmanager.getplugin("xdist"):
 
             class _MypyXdistPlugin:
                 def pytest_configure_node(self, node):  # xdist hook
-                    """Pass config._mypy_results_path to workers."""
-                    _get_xdist_workerinput(node)[
-                        "_mypy_results_path"
-                    ] = node.config._mypy_results_path
+                    """Pass the mypy results path to workers."""
+                    _get_xdist_workerinput(node)["_mypy_results_path"] = str(
+                        node.config.stash[stash_keys["mypy_results_path"]]
+                    )
 
             config.pluginmanager.register(_MypyXdistPlugin())
 
@@ -259,14 +262,14 @@ def from_mypy(
     @classmethod
     def from_session(cls, session) -> "MypyResults":
         """Load (or generate) cached mypy results for a pytest session."""
-        results_path = (
-            session.config._mypy_results_path
+        mypy_results_path = Path(
+            session.config.stash[stash_keys["mypy_results_path"]]
             if _is_xdist_controller(session.config)
             else _get_xdist_workerinput(session.config)["_mypy_results_path"]
         )
-        with FileLock(results_path + ".lock"):
+        with FileLock(str(mypy_results_path) + ".lock"):
             try:
-                with open(results_path, mode="r") as results_f:
+                with open(mypy_results_path, mode="r") as results_f:
                     results = cls.load(results_f)
             except FileNotFoundError:
                 results = cls.from_mypy(
@@ -276,7 +279,7 @@ def from_session(cls, session) -> "MypyResults":
                         if isinstance(item, MypyFileItem)
                     ],
                 )
-                with open(results_path, mode="w") as results_f:
+                with open(mypy_results_path, mode="w") as results_f:
                     results.dump(results_f)
         return results
 
@@ -296,8 +299,9 @@ def pytest_terminal_summary(terminalreporter, config):
     """Report stderr and unrecognized lines from stdout."""
     if not _is_xdist_controller(config):
         return
+    mypy_results_path = config.stash[stash_keys["mypy_results_path"]]
     try:
-        with open(config._mypy_results_path, mode="r") as results_f:
+        with open(mypy_results_path, mode="r") as results_f:
             results = MypyResults.load(results_f)
     except FileNotFoundError:
         # No MypyItems executed.
@@ -309,4 +313,4 @@ def pytest_terminal_summary(terminalreporter, config):
             terminalreporter.write_line(results.unmatched_stdout, **color)
         if results.stderr:
             terminalreporter.write_line(results.stderr, yellow=True)
-    Path(config._mypy_results_path).unlink()
+    mypy_results_path.unlink()

tests/test_pytest_mypy.py

@@ -520,11 +520,13 @@ def test_mypy_no_output(testdir, xdist_args):
 
             @pytest.hookimpl(hookwrapper=True)
             def pytest_terminal_summary(config):
-                mypy_results_path = getattr(config, "_mypy_results_path", None)
-                if not mypy_results_path:
+                pytest_mypy = config.pluginmanager.getplugin("mypy")
+                stash_key = pytest_mypy.stash_keys["mypy_results_path"]
+                try:
+                    mypy_results_path = config.stash[stash_key]
+                except KeyError:
                     # xdist worker
                     return
-                pytest_mypy = config.pluginmanager.getplugin("mypy")
                 with open(mypy_results_path, mode="w") as results_f:
                     pytest_mypy.MypyResults(
                         opts=[],