Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post: deprecate config files without sphinx or mkdocs configuration #342

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Dec 12, 2024

@stsewd stsewd requested a review from a team as a code owner December 12, 2024 21:04
@stsewd stsewd requested a review from ericholscher December 12, 2024 21:04
image: /images/deprecated-config-file-without-sphinx-or-mkdocs-config.jpg
image_credit: Photo by <a href="https://unsplash.com/@jernejgraj?utm_content=creditCopyText&utm_medium=referral&utm_source=unsplash">Jernej Graj</a> on <a href="https://unsplash.com/photos/photo-of-seashore-during-golden-hour-n44KHcbp1_E?utm_content=creditCopyText&utm_medium=referral&utm_source=unsplash">Unsplash</a>

We are announcing the deprecation of configuration files that do not contain a explicit `sphinx` or `mkdocs` configuration.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like bad phrasing, because we support lots of configurations without those keys, especially with build.commands and new build.jobs syntax.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build.commands yes, build.jobs still run sphinx commands. Anyway, what about "Deprecation of projects using Sphinx or MkDocs without an explicit configuration file"? Changed all the sentences to that.

Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I thought we were also defaulting to Sphinx and find config even if you didn't even specify the sphinx: key, right? Will be good to remove that magic.

@stsewd
Copy link
Member Author

stsewd commented Dec 13, 2024

I thought we were also defaulting to Sphinx and find config even if you didn't even specify the sphinx: key, right? Will be good to remove that magic.

Yeah, that's also part of the deprecation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants