Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build pop-up: show error notification if the build has failed #413

Open
humitos opened this issue Jul 4, 2024 · 1 comment
Open

Build pop-up: show error notification if the build has failed #413

humitos opened this issue Jul 4, 2024 · 1 comment
Labels
Bug A bug

Comments

@humitos
Copy link
Member

humitos commented Jul 4, 2024

I think these pop ups are cool. However, it doesn't provide too much extra useful information that the list item. The extra information it provides that's not in the list item is the commit (6225c4b5) and the build time (45 seconds). All the other data it shows in the list item:

Screenshot_2024-07-04_13-36-40

I think we can take advantage of this popup and add the reason for the build to fail here, for example. That way, users don't have to jump into the build details page to understand what happened:

Screenshot_2024-07-04_13-34-38

We could pull the error notifications and show them inside the popup. In this particular case, it would show: No HTML content found -- No content was output to the path "$READTHEDOCS_OUTPUT/html". Read more about where to put your built files.

@humitos humitos added Feature New feature Needed: design decision A core team decision is required labels Jul 4, 2024
@agjohnson
Copy link
Contributor

This was already the case, at least previously:

image

I'm guessing the change to use build notifications might have broke this?

@agjohnson agjohnson added Bug A bug and removed Feature New feature Needed: design decision A core team decision is required labels Jul 8, 2024
@agjohnson agjohnson added this to the Dashboard minor bugs milestone Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A bug
Projects
None yet
Development

No branches or pull requests

2 participants