Merge pull request #254 from SimonFrings/ci

Use GitHub actions for continuous integration (CI)

Author: jsor

.gitattributes

@@ -1,7 +1,7 @@
 /.gitattributes export-ignore
+/.github/ export-ignore
 /.gitignore export-ignore
-/.travis.yml export-ignore
-/examples export-ignore
+/examples/ export-ignore
 /phpunit.xml.dist export-ignore
 /phpunit.xml.legacy export-ignore
-/tests export-ignore
+/tests/ export-ignore

.github/workflows/ci.yml

@@ -0,0 +1,62 @@
+name: CI
+
+on:
+  push:
+  pull_request:
+
+jobs:
+  PHPUnit:
+    name: PHPUnit (PHP ${{ matrix.php }} on ${{ matrix.os }})
+    runs-on: ${{ matrix.os }}
+    strategy:
+      matrix:
+        os:
+          - ubuntu-20.04
+          - windows-2019
+        php:
+          - 8.0
+          - 7.4
+          - 7.3
+          - 7.2
+          - 7.1
+          - 7.0
+          - 5.6
+          - 5.5
+          - 5.4
+          - 5.3
+    steps:
+      - uses: actions/checkout@v2
+      - uses: shivammathur/setup-php@v2
+        with:
+          php-version: ${{ matrix.php }}
+          coverage: xdebug
+      - run: composer install
+      - run: vendor/bin/phpunit --coverage-text
+        if: ${{ matrix.php >= 7.3 }}
+      - run: vendor/bin/phpunit --coverage-text -c phpunit.xml.legacy
+        if: ${{ matrix.php < 7.3 }}
+
+  PHPUnit-macOS:
+    name: PHPUnit (macOS)
+    runs-on: macos-10.15
+    continue-on-error: true
+    steps:
+      - uses: actions/checkout@v2
+      - uses: shivammathur/setup-php@v2
+        with:
+          php-version: 8.0
+          coverage: xdebug
+      - run: composer install
+      - run: vendor/bin/phpunit --coverage-text
+
+  PHPUnit-hhvm:
+    name: PHPUnit (HHVM)
+    runs-on: ubuntu-18.04
+    continue-on-error: true
+    steps:
+      - uses: actions/checkout@v2
+      - uses: azjezz/setup-hhvm@v1
+        with:
+          version: lts-3.30
+      - run: hhvm $(which composer) install
+      - run: hhvm vendor/bin/phpunit

.gitignore

@@ -1,2 +1,2 @@
-composer.lock
-vendor
+/composer.lock
+/vendor/

.travis.yml

@@ -1,6 +1,6 @@
 # Socket
 
-[![Build Status](https://travis-ci.org/reactphp/socket.svg?branch=master)](https://travis-ci.org/reactphp/socket)
+[![CI status](https://github.com/reactphp/socket/workflows/CI/badge.svg)](https://github.com/reactphp/socket/actions)
 
 Async, streaming plaintext TCP/IP and secure TLS socket server and client
 connections for [ReactPHP](https://reactphp.org/).
@@ -1433,7 +1433,7 @@ $ composer require react/socket:^1.6
 See also the [CHANGELOG](CHANGELOG.md) for details about version upgrades.
 
 This project aims to run on any platform and thus does not require any PHP
-extensions and supports running on legacy PHP 5.3 through current PHP 7+ and HHVM.
+extensions and supports running on legacy PHP 5.3 through current PHP 8+ and HHVM.
 It's *highly recommended to use PHP 7+* for this project, partly due to its vast
 performance improvements and partly because legacy PHP versions require several
 workarounds as described below.

README.md

@@ -40,6 +40,10 @@ public function connectionToTcpServerShouldSucceedWithLocalhost()
      */
     public function testConnectTwiceWithoutHappyEyeBallsOnlySendsSingleDnsQueryDueToLocalDnsCache()
     {
+        if ((DIRECTORY_SEPARATOR === '\\' && PHP_VERSION_ID < 70000) || defined('HHVM_VERSION')) {
+            $this->markTestSkipped('Not supported on Windows for PHP versions < 7.0 and legacy HHVM');
+        }
+
         $loop = Factory::create();
 
         $socket = stream_socket_server('udp://127.0.0.1:0', $errno, $errstr, STREAM_SERVER_BIND);
@@ -77,6 +81,9 @@ public function testConnectTwiceWithoutHappyEyeBallsOnlySendsSingleDnsQueryDueTo
      */
     public function connectionToRemoteTCP4n6ServerShouldResultInOurIP()
     {
+        // max_nesting_level was set to 100 for PHP Versions < 5.4 which resulted in failing test for legacy PHP
+        ini_set('xdebug.max_nesting_level', 256);
+
         $loop = Factory::create();
 
         $connector = new Connector($loop, array('happy_eyeballs' => true));

tests/FunctionalConnectorTest.php

@@ -15,7 +15,7 @@
 
 class FunctionalSecureServerTest extends TestCase
 {
-    const TIMEOUT = 0.5;
+    const TIMEOUT = 2;
 
     /**
      * @before
@@ -174,7 +174,7 @@ public function testClientUsesTls10WhenCryptoMethodIsExplicitlyConfiguredByClien
         try {
             $client = Block\await($promise, $loop, self::TIMEOUT);
         } catch (\RuntimeException $e) {
-            if (strpos($e->getMessage(), 'no protocols available') !== false) {
+            if (strpos($e->getMessage(), 'no protocols available') !== false || strpos($e->getMessage(), 'routines:state_machine:internal error') !== false) {
                 $this->markTestSkipped('TLS v1.0 not available on this system');
             }
 

tests/FunctionalSecureServerTest.php

@@ -101,6 +101,10 @@ public function gettingPlaintextStuffFromEncryptedGoogleShouldNotWork()
 
     public function testConnectingFailsIfConnectorUsesInvalidDnsResolverAddress()
     {
+        if (PHP_OS === 'Darwin') {
+            $this->markTestSkipped('Skipped on macOS due to a bug in reactphp/dns (solved in reactphp/dns#171)');
+        }
+
         $loop = Factory::create();
 
         $factory = new ResolverFactory();

tests/IntegrationTest.php

@@ -15,7 +15,7 @@
 
 class SecureIntegrationTest extends TestCase
 {
-    const TIMEOUT = 0.5;
+    const TIMEOUT = 2;
 
     private $loop;
     private $server;